Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_2_X backport] MTD geometry: Fix MTDGeometryBuilder text to avoid rounding issues with alternative architectures #46792

Open
wants to merge 1 commit into
base: CMSSW_14_2_X
Choose a base branch
from

Conversation

fabiocos
Copy link
Contributor

PR description:

Exact backport to CMSSW_14_2_X of #46761 . It requires cms-data/Geometry-TestReference#17

PR validation:

Code was developed and tested on 14_2_X, moved to 15_0_X during PR test.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos for CMSSW_14_2_X.

It involves the following packages:

  • Geometry/MTDGeometryBuilder (geometry, upgrade)

@Dr15Jones, @Moanwar, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@bsunanda, @martinamalberti this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 25, 2024

cms-bot internal usage

@fabiocos
Copy link
Contributor Author

type bugfix

@fabiocos
Copy link
Contributor Author

please test with cms-data/Geometry-TestReference#17

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cb0f84/43048/summary.html
COMMIT: 275d4bf
CMSSW: CMSSW_14_2_X_2024-11-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46792/43048/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 18 lines to the logs
  • Reco comparison results: 27 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3483722
  • DQMHistoTests: Total failures: 1900
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3481802
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: found differences in 1 / 44 workflows

@civanch
Copy link
Contributor

civanch commented Nov 28, 2024

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants