Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ModuleEventAllocMonitor Service #46848

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

Dr15Jones
Copy link
Contributor

PR description:

  • this tracks memory addresses allocated/deallocated in a module on an event by event basis
  • refactored code used from ModuleAllocMonitor

PR validation:

Code compiles. Running on simple tests gave expected results.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2024

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • PerfTools/AllocMonitor (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@felicepantaleo, @makortel this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2024

-1

Failed Tests: HeaderConsistency RelVals-INPUT
Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b6e5b/43195/summary.html
COMMIT: f043764
CMSSW: CMSSW_15_0_X_2024-12-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46848/43195/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 2024.002001DAS Error
  • 2024.000001DAS Error
  • 2024.003001DAS Error
Expand to see more relval errors ...
  • 2024.103001
  • 2024.101001
  • 2023.000001
  • 2024.001001
  • 2022.001001
  • 2024.100001

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3484682
  • DQMHistoTests: Total failures: 507
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3484155
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: found differences in 1 / 44 workflows

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2024

Pull request #46848 was updated. @Dr15Jones, @makortel, @smuzaffar can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2024

-1

Failed Tests: HeaderConsistency
Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b6e5b/43210/summary.html
COMMIT: 3dbd315
CMSSW: CMSSW_15_0_X_2024-12-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46848/43210/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3484682
  • DQMHistoTests: Total failures: 487
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3484175
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: found differences in 1 / 44 workflows

- refactored code used from ModuleAllocMonitor
@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #46848 was updated. @Dr15Jones, @makortel, @smuzaffar can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b6e5b/43418/summary.html
COMMIT: 3121f37
CMSSW: CMSSW_15_0_X_2024-12-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46848/43418/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

@makortel
Copy link
Contributor

+core

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1ac1ab8 into cms-sw:master Dec 16, 2024
11 checks passed
@Dr15Jones Dr15Jones deleted the moduleEventAlloc branch December 17, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants