-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ModuleEventAllocMonitor Service #46848
Conversation
please test |
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46848/42865 |
A new Pull Request was created by @Dr15Jones for master. It involves the following packages:
@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Failed Tests: HeaderConsistency RelVals-INPUT RelVals-INPUT
Expand to see more relval errors ...
Comparison SummarySummary:
|
f043764
to
3dbd315
Compare
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46848/42874 |
Pull request #46848 was updated. @Dr15Jones, @makortel, @smuzaffar can you please check and sign again. |
-1 Failed Tests: HeaderConsistency Comparison SummarySummary:
|
- refactored code used from ModuleAllocMonitor
0cb6fe6
to
3121f37
Compare
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46848/42990 |
Pull request #46848 was updated. @Dr15Jones, @makortel, @smuzaffar can you please check and sign again. |
+1 Size: This PR adds an extra 28KB to repository
Comparison SummarySummary:
|
+core |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
PR validation:
Code compiles. Running on simple tests gave expected results.