ECAL - Make EcalUncalibRecHitSoAToLegacy a global module

[thomreis]

PR description:

This PR changes the EcalUncalibRecHitSoAToLegacy from a stream to a global module as suggested here.
In addition the parameter names for inputs and output labels are simplified and aligned to changes in the equivalent module of the calibrated rechit module as mentioned in this comment.

No changes expected in output.

PR validation:

Passes 12834.412.

[cmsbuild]

cms-bot internal usage

[thomreis]

type ecal

[thomreis]

enable gpu

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46935/43005

[cmsbuild]

A new Pull Request was created by @thomreis for master.

It involves the following packages:

• HLTrigger/Configuration (hlt)
• RecoLocalCalo/EcalRecProducers (reconstruction)

@Martin-Grunewald, @cmsbuild, @jfernan2, @mandrenguyen, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @ReyerBand, @apsallid, @argiro, @denizsun, @missirol, @mmusich, @rchatter, @salimcerci, @silviodonato, @thomreis, @wang0jin, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[thomreis]

please test

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3adbeb/43439/summary.html
COMMIT: 68ecab5
CMSSW: CMSSW_15_0_X_2024-12-13-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46935/43439/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3510017
• DQMHistoTests: Total failures: 407
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3509590
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 202 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 7
• DQMHistoTests: Total histograms compared: 53058
• DQMHistoTests: Total failures: 35
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 53023
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
• Checked 24 log files, 30 edm output root files, 7 DQM output files
• TriggerResults: no differences found

[mmusich]

+hlt

[jfernan2]

+1

[cmsbuild]

Pull request #46935 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

[thomreis]

Just tried squashing all commits but the conflict is still there. It identifies my newly added customization function as a conflict.

[Martin-Grunewald]

It is likely due to the merging of #46938 today.

[mmusich]

Just tried squashing all commits but the conflict is still there. It identifies my newly added customization function as a conflict.

@thomreis you need to rebase against the HEAD of CMSSW_15_0_X, not an IB.
Doing so I get a clean commit that merges just fine: link

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46935/43029

[cmsbuild]

Pull request #46935 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3adbeb/43469/summary.html
COMMIT: 4302286
CMSSW: CMSSW_15_0_X_2024-12-15-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46935/43469/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @mmusich add stub of DeDxCalibration Payload Inspector #46920
• @Dr15Jones Improved calculation of CRC32 #46936
• @iarspider Fix DQM config test: Increase number of sequences to process #46923
• @martinamalberti [MTD Validation]: update to MtdTracksValidation #46931
• @makortel Extend SimpleMemoryCheck service to report jemalloc and smaps information, and on early termination signal #46859
• @Dr15Jones Added ModuleEventAllocMonitor Service #46848
• @Dr15Jones Fixed memory leak in RegionalMuonGMTUnpacker #46918
• @dan131riley silence clang vectorization warnings #46944
• @perrotta Update MC GTs for Winter25 and 2024 HI/ppRef in autoCond - CMSSW_150X #46945
• @Dr15Jones Clear memory at end of event in DeepFlavourONNXJetTagsProducer #46941
• @cms-tsg-storm HLT menu development for 14_2_X (1/N) [15_0_X] #46938

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3adbeb/43469/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3adbeb/43469/git-merge-result

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• You potentially added 133 lines to the logs
• Reco comparison results: 3028 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3510009
• DQMHistoTests: Total failures: 61329
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3448660
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.11199999999999999 KiB( 45 files compared)
• DQMHistoSizes: changed ( 139.001,... ): -0.001 KiB HLT/Filters
• DQMHistoSizes: changed ( 16834.0,... ): 0.023 KiB HLT/Filters
• Checked 202 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: found differences in 2 / 44 workflows

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 24 differences found in the comparisons
• DQMHistoTests: Total files compared: 7
• DQMHistoTests: Total histograms compared: 53058
• DQMHistoTests: Total failures: 873
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 52185
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
• Checked 24 log files, 30 edm output root files, 7 DQM output files
• TriggerResults: no differences found

[mmusich]

+hlt

• comparisons at ECAL - Make EcalUncalibRecHitSoAToLegacy a global module #46935 (comment) are not clean, but since last signature only a rebase was pushed in this branch

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1