Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the signature of allocMappedBuf #47119

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jan 17, 2025

PR description:

Update the signature of allocMappedBuf for alpaka 1.2.0

PR validation:

None.

If this PR will be backported please specify to which release cycle the backport is meant for:

Not to be backported.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 17, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47119/43339

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47119/43341

@cmsbuild
Copy link
Contributor

Pull request #47119 was updated.

@fwyzard fwyzard changed the title Update CMSSW for alpaka 1.2.0 Update the signature of allocMappedBuf Jan 17, 2025
@fwyzard fwyzard marked this pull request as ready for review January 17, 2025 08:19
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

  • HeterogeneousCore/AlpakaInterface (heterogeneous)

@cmsbuild, @fwyzard, @makortel can you please review it and eventually sign? Thanks.
@makortel, @missirol, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 17, 2025

+heterogeneous

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 17, 2025

This is being tested as part of cms-sw/cmsdist#9619 .

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 17, 2025

please test with cms-sw/cmsdist#9619

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build ClangBuild
Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-358492/43821/summary.html
COMMIT: b409f96
CMSSW: CMSSW_15_0_X_2025-01-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47119/43821/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-358492/43821/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-358492/43821/git-merge-result

Build

I found compilation error when building:

>> Leaving Package DataFormats/Portable
>> Package DataFormats/Portable built
Copying tmp/el8_amd64_gcc12/src/RecoLocalCalo/EcalRecProducers/plugins/RecoLocalCaloEcalRecProducersPluginsPortableROCmAsync/libRecoLocalCaloEcalRecProducersPluginsPortableROCmAsync_rocm.a to productstore area:
cp: cannot stat 'tmp/el8_amd64_gcc12/src/RecoLocalCalo/EcalRecProducers/plugins/RecoLocalCaloEcalRecProducersPluginsPortableROCmAsync/libRecoLocalCaloEcalRecProducersPluginsPortableROCmAsync_rocm.a': No such file or directory
>> Deleted: tmp/el8_amd64_gcc12/src/RecoLocalCalo/EcalRecProducers/plugins/RecoLocalCaloEcalRecProducersPluginsPortableROCmAsync/libRecoLocalCaloEcalRecProducersPluginsPortableROCmAsync_rocm.a
gmake: *** [config/SCRAM/GMake/Makefile.rules:1888: tmp/el8_amd64_gcc12/src/RecoLocalCalo/EcalRecProducers/plugins/RecoLocalCaloEcalRecProducersPluginsPortableROCmAsync/libRecoLocalCaloEcalRecProducersPluginsPortableROCmAsync_rocm.a] Error 1
>> Entering Package RecoTracker/MkFitCMS
>> Leaving Package RecoTracker/MkFitCMS
>> Package RecoTracker/MkFitCMS built
Entering library rule at RecoTracker/MkFitCMS
>> Compiling  src/RecoTracker/MkFitCMS/src/MkSeedPartitioners-phase1.cc


Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' /usr/bin/time -v scram build -k -j 32 COMPILER='llvm compile'

>> Entering Package TrackPropagation/Geant4e
>> Entering Package TrackPropagation/RungeKutta
>> Entering Package TrackPropagation/SteppingHelixPropagator
>> Entering Package Utilities/ReleaseScripts
>> Compile sequence completed for CMSSW CMSSW_15_0_X_2025-01-16-2300
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
Command exited with non-zero status 1
	Command being timed: "scram build -k -j 32 COMPILER=llvm compile BUILD_LOG=yes"
	User time (seconds): 39812.13
	System time (seconds): 4739.96
	Percent of CPU this job got: 1451%


@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 17, 2025

please test with cms-sw/cmsdist#9619, #47120

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-358492/43832/summary.html
COMMIT: b409f96
CMSSW: CMSSW_15_0_X_2025-01-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47119/43832/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-358492/43832/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-358492/43832/git-merge-result

Comparison Summary

Summary:

@cmsbuild
Copy link
Contributor

REMINDER @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy: This PR was tested with cms-sw/cmsdist#9619, please check if they should be merged together

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2ecfaf0 into cms-sw:master Jan 21, 2025
11 checks passed
@fwyzard fwyzard deleted the update_alpaka_1.2.0 branch January 21, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants