draft of downloading sources from pypi instead of pip #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @davidlange6 (David Lange) for branch V00-32-XX. @cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks. |
|
could you cherry-pick this commit against 33 branch, we dont't use 32 anymore. Although it's the default we are using the 33 XX (maybe we'll have to change the default sometime) |
|
Ha - was wondering about 33. Will do.
… On Apr 21, 2021, at 3:03 PM, Mircho Rodozov ***@***.***> wrote:
could you cherry-pick this commit against 33 branch, we dont't use 32 anymore. Although it's the default we are using the 33 XX (maybe we'll have to change the default sometime)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
I guess we don't need this PR |
|
changes looks good and although we are not using V00-32-XX branch but it does not hurt to get this feature in V32 too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like newer pip versions have issues supporting source downloads. So far this has been worked around by changing to a binary distribution - as we start to drop python2 support (eg, the older pip), this problem will come up frequently.
This is a proposed way around that as an alternative to using wheels everywhere (eg, using --no-binary=none). This follows the advice of pypa/pip#9701
@smuzaffar @mrodozov