Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds White Webbing and fixes dueling vest #2944

Closed

Conversation

realforest2001
Copy link
Member

About the pull request

Adds white webbing with a surgical and non surgical preset. Fixes the inability to put dueling knives back into their harness.

Explain why it's good for the game

Style points

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Adds white webbing, with surgical and non surgical presets.
fix: Dueling knives can now be put back into their starting holsters.
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Feature Feature coder badge Fix Fix one bug, make ten more labels Mar 24, 2023
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Mar 31, 2023
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Apr 12, 2023
@realforest2001
Copy link
Member Author

Pending a sprite tweak courtesy of QuickLoad

@github-actions github-actions bot removed the Stale beg a maintainer to review your PR label Apr 13, 2023
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Apr 18, 2023
@@ -613,6 +626,7 @@
/obj/item/storage/internal/accessory/knifeharness/duelling
storage_slots = 2
max_storage_space = 2
max_w_class = 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there weight class defines

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label May 2, 2023
@github-actions github-actions bot closed this May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Fix Fix one bug, make ten more Merge Conflict PR can't be merged because it touched too much code Sprites Remove the soul from the game. Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants