added camera shake and stun to OB. #3605
Conversation
|
You currently have a negative Fix/Feature pull request delta of -2. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score. |
ghost
added
Do Not Merge
ghost
self-requested a review
|
Fixed the requested changes and should be ready for testing @morrowwolf |
harryob
added
the
Testmerge Candidate
ghost
marked this pull request as draft
ghost
marked this pull request as ready for review
| @@ -293,6 +293,52 @@ as having entered the turf. | |||
| create_shrapnel(epicenter, rand(5,9), , ,/datum/ammo/bullet/shrapnel/light/effect/ver1, explosion_cause_data) | |||
| create_shrapnel(epicenter, rand(5,9), , ,/datum/ammo/bullet/shrapnel/light/effect/ver2, explosion_cause_data) | |||
|
|
|||
| // everything below this line is strictly for handling ob camera shakes | |||
| // it can be modified in the future to handle other explosion types by interacting with power and falloff instead. | |||
| if(!warhead_kind) | |||
There was a problem hiding this comment.
I think all of this should really be handled in OB code. If you're specifying "warhead_kind" you're looking at something that likely should be handled via object oriented programming. Sorry to have you refactor it again 😶
There was a problem hiding this comment.
It was initially like that but moving it here was the solution I found to fix the runtime, I moved it over with the expectation someone down the line would want to integrate the camera shake with this proc (current implementation is a bit hacky ngl). I'll move it back if need be.
ghost
marked this pull request as draft
|
Not exactly sure what happened but I messed up this branch, created a new one. #3658 |
ghost
mentioned this pull request
ghost
closed this
# About the pull request Added a camera shake and stun feature based on the user's distance to the OB. This is a copy of an existing branch that I somehow managed to mess up -> #3605 # Explain why it's good for the game OBs should feel like OBs, and adding this feature just helps make OBs feel like an actual large explosion. # Changelog :cl: add: added camera shake and stun to OB. /:cl:
About the pull request
Added a camera shake and stun feature based on the user's distance to the OB.
Explain why it's good for the game
OBs should feel like OBs, and adding this feature just helps make OBs feel like an actual large explosion.
Changelog
🆑
add: added camera shake and stun to OB.
/:cl: