Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linked LZ Adjustments and Remote Queen Boosted Building Restrictions #7535

Merged
merged 4 commits into from
Nov 10, 2024

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Nov 8, 2024

About the pull request

This PR is a follow up to #7363 and #7376 where the linked_lz area var has been adjusted on all maps in rotation. This required area changes on Shivas (fix misplaced areas) and Trijent (cut tcoms area and made a new area).

Queen boosted remote building is now prevented in linked_lz areas. This can help with remote building being used heavily against survivors, but likely won't have a large impact unless the lz gas proves removeable (I will be exploring it next).

Explain why it's good for the game

All maps need to have properly set up LZ linked weed restricted areas so that weeds can be properly removed/prevented when marines land. Chances Claim for example wasn't using the mechanic at all.

Queen remote building is primarily intended to establish a foothold when it is in its boosted state. If the LZ linked weed restricted areas mechanic would just be destroying her structures anyways, its best to prevent this while also letting up the queen's pressure on survivors at least on certain parts of the map.

Testing Photographs and Procedure

Screenshots & Videos

Chances
Chances2
Fiorina
Fiorina2
Kutjevo
Kutjevo2
LV624
LV624_2
Shivas
Shivas3
Solaris
Solaris2
Soro
Soro2
Trijent
Trijent2
Varadero
Varadero2

Changelog

🆑 Drathek
balance: Queen remote building (while boosted) is now prevented in LZ linked weed restricted areas
balance: Adjusted/added LZ linked weed restriction areas on all maps in rotation
maptweak: Fixed misplaced areas on Shivas.
maptweak: Split the Telecoms Valley area to make a Security Valley area on Trijent.
/:cl:

Area fixes on Kutjevo and Shivas
…ents

# Conflicts:
#	maps/map_files/Ice_Colony_v3/Shivas_Snowball.dmm
@Drulikar Drulikar requested a review from Nanu308 as a code owner November 8, 2024 11:22
@cmss13-ci cmss13-ci bot added Mapping did you remember to save in tgm format? Balance You need to be a professional veteran game maintainer to comprehend what is being done here. labels Nov 8, 2024
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Nov 9, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Nanu308 Nanu308 added Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Mapping Approved adds 500 new dict keys labels Nov 9, 2024
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good area tweaks and changes, plus good catches on the bugged areas 👍

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Nov 9, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Drulikar Drulikar added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Nov 9, 2024
cm13-github added a commit that referenced this pull request Nov 9, 2024
@BOBAMAx

This comment was marked as off-topic.

@Drulikar
Copy link
Contributor Author

This doesn't prevent queen from remote weeding in linked_lz areas but from a sample size of 1 round queen seems to focus more on using boost to build backline defenses instead of focusing only on survs.

I intentionally did not prevent remote weeding.

cm13-github added a commit that referenced this pull request Nov 10, 2024
@kindadread2 kindadread2 mentioned this pull request Nov 10, 2024
3 tasks
@Nanu308 Nanu308 added this pull request to the merge queue Nov 10, 2024
Merged via the queue into cmss13-devs:master with commit 9d42460 Nov 10, 2024
28 checks passed
cmss13-ci bot added a commit that referenced this pull request Nov 10, 2024
@Drulikar Drulikar deleted the Linked_LZ_Adjustments branch November 11, 2024 00:19
github-merge-queue bot pushed a commit that referenced this pull request Nov 12, 2024
# About the pull request

This PR is a follow up to #7363 and #7535 where the LZ miasma hazard is
now a toggleable flag during the first 3 minutes of round by admins. It
is disabled by default (as in no longer LZ miasma smoke by default).

# Explain why it's good for the game

Although the LZ smoke is successful in getting survivors out of the
landing zones, there is no longer the aspect of trying to push survivors
closer to weedable areas now that everywhere is weedable. It is awkward
for xenos if survivors back themselves up to the smoke and have no
possible flank.

The reason for making it a toggle is just because I think there can be
events that utilize it, or if staff otherwise wants to experiment with
this mechanic.

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>


![1](https://github.com/user-attachments/assets/f0cee1fd-caed-43f2-a562-6ec3313926ed)

![2](https://github.com/user-attachments/assets/6614d334-a775-4496-b1ee-054ce6d23959)

![3](https://github.com/user-attachments/assets/a77140fc-83f1-4c0e-ad5d-b11511a733de)

</details>


# Changelog
:cl: Drathek
balance: LZ smoke is now disabled by default on distress signal
admin: Added game mode toggle to toggle LZ smoke during the first 3
minutes of the round (otherwise is locked in)
/:cl:
github-merge-queue bot pushed a commit that referenced this pull request Nov 12, 2024
# About the pull request

This PR is a follow up to #7363 and #7535 where the LZ miasma hazard is
now a toggleable flag during the first 3 minutes of round by admins. It
is disabled by default (as in no longer LZ miasma smoke by default).

# Explain why it's good for the game

Although the LZ smoke is successful in getting survivors out of the
landing zones, there is no longer the aspect of trying to push survivors
closer to weedable areas now that everywhere is weedable. It is awkward
for xenos if survivors back themselves up to the smoke and have no
possible flank.

The reason for making it a toggle is just because I think there can be
events that utilize it, or if staff otherwise wants to experiment with
this mechanic.

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>


![1](https://github.com/user-attachments/assets/f0cee1fd-caed-43f2-a562-6ec3313926ed)

![2](https://github.com/user-attachments/assets/6614d334-a775-4496-b1ee-054ce6d23959)

![3](https://github.com/user-attachments/assets/a77140fc-83f1-4c0e-ad5d-b11511a733de)

</details>


# Changelog
:cl: Drathek
balance: LZ smoke is now disabled by default on distress signal
admin: Added game mode toggle to toggle LZ smoke during the first 3
minutes of the round (otherwise is locked in)
/:cl:
github-merge-queue bot pushed a commit that referenced this pull request Nov 19, 2024
# About the pull request

This PR is a follow up to #7363 #7556 and #7535 which have been changing
where xenos are allowed to weed. This should be the final update to
allow xenos weeding capabilities anywhere but OOB and the AI Core
(atleast until marines land then there is a temporary restriction).

Also fixes an oversight where resin walls and doors were not getting
weed killed.

# Explain why it's good for the game

Fixes #7583

# Testing Photographs and Procedure
<!-- Include any screenshots/videos/debugging steps of the modified code
functioning successfully, ideally including edge cases. -->

<!-- !! If you are modifying sprites, you **must** include one or more
in-game screenshots or videos of the new sprites. !! -->

<details>
<summary>Screenshots & Videos</summary>

https://youtu.be/0qA55ZizGoE

Weed killer on structures:

![example](https://github.com/user-attachments/assets/fe56de81-8381-45b1-93e1-6d06612cde5c)

</details>

# Changelog
:cl: Drathek
code: Added sanity checks for whenever AREA_UNWEEDABLE is used or when
an area is somehow null
balance: All maps have their round start is_resin_allowed restriction
lifted unless out of bounds
maptweak: All maps with OOB areas have now AREA_UNWEEDABLE set to make
the restriction permanent
fix: Resin walls and doors will now properly get weed killed
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format? Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants