ARX classifier vignette #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajmcdon
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Everything here looks really good. Most of the below are suggestions that you can batch together into 1 commit directly from the PR review panel. A few thoughts:
- Supposedly, the vignette linking will happen automatically.
- Is it worth trying the
n_trainingargument rather than filtering the data to start? - Would it be worth illustrating everything again with another engine (maybe LDA or random forests)? If so, additional required packages go in Suggests.
dajmcdon
approved these changes
Apr 11, 2024
This was referenced Apr 11, 2024
Merged
Co-authored-by: Daniel McDonald <dajmcdon@gmail.com>
Co-authored-by: Daniel McDonald <dajmcdon@gmail.com>
Co-authored-by: Daniel McDonald <dajmcdon@gmail.com>
Co-authored-by: Daniel McDonald <dajmcdon@gmail.com>
Co-authored-by: Daniel McDonald <dajmcdon@gmail.com>
…pipredict into vignette-classifier
|
To address your main points 1. sounds good to me. For 2., I did have a version of the vignette with this, but I ended up removing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch has the ARX classifier vignette we went over (I removed the one heatmap that you didn't like that ended up looking more like a bar chart).