Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unique bundle names #704

Merged
merged 3 commits into from
Dec 30, 2020
Merged

unique bundle names #704

merged 3 commits into from
Dec 30, 2020

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Dec 30, 2020

Prerequisites:

  • Unless it is a hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

creates unique bundle names by using webpacks contenthash within the file name. However, this requires cmu-delphi/www-main#204 such that www-main also respects the new names.

This will avoid that the website and covidcast are out of sync on a client. A new version of the website will request a different filename from the server, thus a old browser cache hit won't be possible. An old version of the website will also request an old version of covidcast so also from this direction no problem anymore

@netlify
Copy link

netlify bot commented Dec 30, 2020

✔️ Preview link ready!

🔨 Explore the source changes: 1715a16

🔍 Inspect the deploy logs: https://app.netlify.com/sites/cmu-delphi-covidcast/deploys/5fec84c6e0712500081c8d1c

😎 Browse the preview: https://deploy-preview-704--cmu-delphi-covidcast.netlify.app

Copy link
Contributor

@tildechris tildechris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgratzl sgratzl merged commit 1ad78d8 into dev Dec 30, 2020
@sgratzl sgratzl deleted the sgratzl/cachebusting branch December 30, 2020 14:06
@sgratzl sgratzl mentioned this pull request Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants