Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find covidcast files dynamically #204

Merged
merged 2 commits into from
Dec 30, 2020
Merged

find covidcast files dynamically #204

merged 2 commits into from
Dec 30, 2020

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Dec 30, 2020

find the covidcast bundle files (css, js) by prefix instead of a direct name which is the requirement for: cmu-delphi/www-covidcast#704

@netlify
Copy link

netlify bot commented Dec 30, 2020

✔️ Deploy preview for cmu-delphi-main ready!

🔨 Explore the source changes: b9935db

🔍 Inspect the deploy logs: https://app.netlify.com/sites/cmu-delphi-main/deploys/5fec83d3edea540007eb2540

😎 Browse the preview: https://deploy-preview-204--cmu-delphi-main.netlify.app

@sgratzl sgratzl requested a review from tildechris December 30, 2020 13:47
@sgratzl sgratzl self-assigned this Dec 30, 2020
@sgratzl sgratzl marked this pull request as ready for review December 30, 2020 13:47
@sgratzl sgratzl mentioned this pull request Dec 30, 2020
Copy link
Contributor

@tildechris tildechris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I pulled down www-covidcast#1ad78d8535bba672da106c4949942482a1047c6d to test and I see the hashes in all of the js bundles.

@sgratzl sgratzl merged commit 67d9db3 into dev Dec 30, 2020
@sgratzl sgratzl deleted the sgratzl/cachebusting branch December 30, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants