Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make specs-go a module #170

Merged
merged 2 commits into from
Oct 30, 2023
Merged

make specs-go a module #170

merged 2 commits into from
Oct 30, 2023

Commits on Oct 30, 2023

  1. make specs-go a module 

    This should allow to import CDI spec structures without adding
a lot of CDI runtime deps.

It should partly fix cncf-tags#97 and allow Kubernetes to refer this module directly.
There are at least 2 places in the k/k codebase that would benefit
from this change:
- this can be replaced by the specs-go import:
  https://github.com/kubernetes/kubernetes/blob/master/test/e2e/dra/test-driver/app/cdi.go
- this can import specs-go and use JSON marshalling instead of
  quite ugly approach it uses to write CDI files:
  https://github.com/kubernetes/kubernetes/blob/master/test/images/sample-device-plugin/sampledeviceplugin.go#L237

Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
    @bart0sh @elezar
    bart0sh authored and elezar committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    6db77f6 View commit details
    Browse the repository at this point in the history

  2. Add replace rule to validate module 

    Signed-off-by: Evan Lezar <elezar@nvidia.com>
    @elezar
    elezar committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    85e2e5b View commit details
    Browse the repository at this point in the history