[ko] Translate 'Cluster' #1131
Merged
[ko] Translate 'Cluster' #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kidae92
requested review from
seokho-son,
Eviekim,
jihoon-seo and
yunkon-kim
as code owners
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@kidae92 기여 감사합니다 ^^ DCO와 관련하여 해결해주실 부분이 있습니다. 현재 열려있는 PR을 참고하시기 바랍니다. |
Signed-off-by: kidae92 <kidae92@hanmail.net>
yunkon-kim
reviewed
Jul 29, 2022
There was a problem hiding this comment.
@kidae92 리뷰 의견을 드립니다 ^^
전반적으로 매끄럽게 다듬는 차원의 의견을 드렸습니다.
기여자께서 판단하시어 적용할 것은 적용하시고, 논의할 내용은 답글로 남겨주시면 되겠습니다.
|
PTAL @kidae92 안녕하세요 ^^ 첫 번쨰로 드린 리뷰 코멘트를 반영하신 후에, 두 번째 리뷰가 진행될 예정입니다. 참고하시기 바라며, 혹시 리뷰 코멘트 해결에 이슈가 있으시면 말씀해주십시오. |
Signed-off-by: kidae92 <kidae92@hanmail.net>
Signed-off-by: kidae92 <kidae92@hanmail.net>
yunkon-kim
approved these changes
Aug 11, 2022
seokho-son
reviewed
Aug 17, 2022
Signed-off-by: kidae92 <kidae92@hanmail.net>
bart2001
reviewed
Aug 28, 2022
seokho-son
approved these changes
Sep 6, 2022
There was a problem hiding this comment.
LGTM :)
@kidae92
마지막에 추가된 커밋에 sign-off 가 빠져 있어서,
DCO가 실패되고 있습니다. :)
가능하시면 커밋을 1개로 스쿼싱해주시면서, sign-off가 되도록 처리 부탁 드립니다.
(또는 @yunkon-kim 께서 해당 PR을 스쿼시 머지 방식으로 DCO에 문제없도록 처리해주셔도 괜찮을 것 같습니다. 향후 가이드는 @yunkon-kim 님께 맡기겠습니다. ㅎㅎ)
|
@seokho-son @kidae92 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant with #1116 (comment)