Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localize service-mesh fr #1272

Merged
merged 7 commits into from
Feb 5, 2023
Merged

Localize service-mesh fr #1272

merged 7 commits into from
Feb 5, 2023

Conversation

Krast76
Copy link
Collaborator

@Krast76 Krast76 commented Aug 27, 2022

Fix #1262

Localize content/fr/service-mesh.md to fr.

@Krast76 Krast76 added the lang/fr for French label Aug 27, 2022
@Krast76 Krast76 requested review from huats and fydrah as code owners August 27, 2022 16:55
@netlify
Copy link

netlify bot commented Aug 27, 2022 •
edited
Loading

✅ Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit e3bd7b2
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/63d2be1c90ec5d00082c6ee9
😎 Deploy Preview https://deploy-preview-1272--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

huats
huats requested changes Aug 31, 2022
View reviewed changes
Copy link
Collaborator

@huats huats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

De plus je suis pour changer le mot service mesh par maillage de services. Etant donné qu'il s'agit un terme on pourrait peut etre citer le terme anglais et la traduction FR.

content/fr/service-mesh.md Outdated Show resolved Hide resolved
content/fr/service-mesh.md Outdated Show resolved Hide resolved
content/fr/service-mesh.md Outdated Show resolved Hide resolved
content/fr/service-mesh.md Outdated Show resolved Hide resolved
content/fr/service-mesh.md Outdated Show resolved Hide resolved
content/fr/service-mesh.md Outdated Show resolved Hide resolved
@Krast76
Copy link
Collaborator Author

Krast76 commented Sep 11, 2022

De plus je suis pour changer le mot service mesh par maillage de services. Etant donné qu'il s'agit un terme on pourrait peut etre citer le terme anglais et la traduction FR.

Je n'appelle jamais ça "maillage de service" dans mon quotidien. Néanmoins, dans la traduction Coréenne (ko) c'est ce qu'ils ont fait, reparlons en à notre prochain point

@huats
Copy link
Collaborator

huats commented Sep 28, 2022

De plus je suis pour changer le mot service mesh par maillage de services. Etant donné qu'il s'agit un terme on pourrait peut etre citer le terme anglais et la traduction FR.

Je n'appelle jamais ça "maillage de service" dans mon quotidien. Néanmoins, dans la traduction Coréenne (ko) c'est ce qu'ils ont fait, reparlons en à notre prochain point

Par contre "des services maillés" oui moi je l'utilise souvent

fydrah
fydrah suggested changes Oct 13, 2022
View reviewed changes
content/fr/service-mesh.md Outdated Show resolved Hide resolved
content/fr/service-mesh.md Outdated Show resolved Hide resolved
content/fr/service-mesh.md Outdated Show resolved Hide resolved
content/fr/service-mesh.md Show resolved Hide resolved
content/fr/service-mesh.md Outdated Show resolved Hide resolved
@Krast76 Krast76 force-pushed the servicemesh-fr branch 2 times, most recently from d5da28b to e61b52c Compare November 1, 2022 15:31
@Krast76
Localize service-mesh fr
9f274fc 
Signed-off-by: Ludovic Logiou <ludovic.logiou@gmail.com>
@Krast76
Add feedbacks from Huats
e9b1a46 
Signed-off-by: Ludovic Logiou <ludovic.logiou@gmail.com>
@Krast76
Fix after title have been changed from the template
b484eb3 
Signed-off-by: Ludovic Logiou <ludovic.logiou@gmail.com>
@Krast76
Replace Service Mesh by maillage de services in the title
691b438 
Signed-off-by: Ludovic Logiou <ludovic.logiou@gmail.com>
@Krast76
Add fydrah insights
dba837d 
Signed-off-by: Ludovic Logiou <ludovic.logiou@gmail.com>
@Krast76
Fix last error about dette technique
2a09c2f 
Signed-off-by: Ludovic Logiou <ludovic.logiou@gmail.com>
@Krast76 Krast76 requested review from fydrah and huats November 26, 2022 15:25
fydrah
fydrah suggested changes Jan 25, 2023
View reviewed changes
content/fr/service-mesh.md Outdated Show resolved Hide resolved
@Krast76
Add review from Fydrah
e3bd7b2 
Signed-off-by: Ludovic Logiou <ludovic.logiou@gmail.com>
@Krast76 Krast76 requested a review from fydrah January 26, 2023 17:53
huats
huats approved these changes Feb 5, 2023
View reviewed changes
Copy link
Collaborator

@huats huats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Krast76 Krast76 merged commit 3c63671 into cncf:dev-fr Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fydrah fydrah fydrah approved these changes

@huats huats huats approved these changes

Assignees

@Krast76 Krast76

Labels
lang/fr for French
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Krast76 @huats @fydrah