Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bcubk as German localization approver #1464

Merged
merged 2 commits into from
Nov 18, 2022

Conversation

seokho-son
Copy link
Collaborator

@seokho-son seokho-son commented Nov 16, 2022

Signed-off-by: Seokho Son shsongist@gmail.com

Describe your changes

  • Update dev-de approvers

Related issue number or link

Based on the following request from the German team.

This PR replace existing approver with a new approver for dev-it

  • Confirmation from the new approver @bcubk

Important

  • All new candidates need to leave a comment in this PR that you understood the following policies and information. (l10n teams: please share this message to candidates)
  • The l10n team approvers need to use your permission appropriately.
    • The approvers of l10n team will have a push permission to this repository.
      It is to make l10n approvers manage (merge) PRs for l10n contributions in your development branch.
      Merging a PR to the main branch by l10n approvers is restricted.
      Even if they are possible to review a PR to the main branch and give an approval to the PR, they should not approve the PR.
      So, please do not approve if a PR is not related with your localization.
  • After this PR merged, the approvers will get an github invitation for collaborate from settings[bot] of cncf/glossary. You need to accept. Please find the invitation from Email or Github notification. It the candidate does not accept it, maintainers cannot assign you as an approver of dev-xx branch.

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO.

Signed-off-by: Seokho Son <shsongist@gmail.com>
Signed-off-by: Seokho Son <shsongist@gmail.com>
@netlify
Copy link

netlify bot commented Nov 16, 2022

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 149a8e3
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6374b929eb54460008fdbc8d
😎 Deploy Preview https://deploy-preview-1464--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@seokho-son seokho-son added the maintainers Use this label if PR requires maintainers to take action label Nov 16, 2022
@bcubk
Copy link
Collaborator

bcubk commented Nov 16, 2022

@seokho-son, I understood the policies and informations about localization approver and confirm it.

@seokho-son
Copy link
Collaborator Author

PTAL @jihoon-seo :)

@jihoon-seo jihoon-seo merged commit cdac4e5 into cncf:main Nov 18, 2022
@iamNoah1
Copy link
Collaborator

Wohoo

seokho-son added a commit to seokho-son/glossary that referenced this pull request Mar 20, 2023
Signed-off-by: Seokho Son <shsongist@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainers Use this label if PR requires maintainers to take action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants