Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bcubk as German localization approver #1464

Merged
merged 2 commits into from
Nov 18, 2022
Merged

Add bcubk as German localization approver #1464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
299a1d1
Update CODEOWNERS
seokho-son Nov 16, 2022
149a8e3
Update settings.yml
seokho-son Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/settings.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ collaborators:
# Localization approvers
# l10n ko approvers
# Note: seokho-son is both Maintainer (maintain) and Korean approver (push)
# Note: jihoon-seo is both English approver (push) and Korean approver (push)
# Note: jihoon-seo is both Maintainer (maintain) and Korean approver (push)
- username: Eviekim
permission: push

Expand Down Expand Up @@ -78,9 +78,12 @@ collaborators:

# l10n de approvers
# Note: CathPag is both Maintainer (maintain) and de approver (push)
# Note: iamNoah1 is both English approver (push) and de approver (push)
# Note: iamNoah1 is both Maintainer (maintain) and de approver (push)
- username: DaveVentura
permission: push

- username: bcubk
permission: push

# l10n it approvers
- username: fsbaraglia
Expand Down Expand Up @@ -258,6 +261,7 @@ branches:
users:
- iamNoah1
- DaveVentura
- bcubk
teams: []
enforce_admins: null
required_linear_history: null
Expand Down
2 changes: 1 addition & 1 deletion CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
/content/hi/ @Garima-Negi @sayantani11 @anubha-v-ardhan @jayesh-srivastava

# Approvers for German contents
/content/de/ @iamNoah1 @DaveVentura @CathPag
/content/de/ @iamNoah1 @DaveVentura @CathPag @bcubk

# Approvers for Italian contents
/content/it/ @fsbaraglia @meryem-ldn @annalisag-spark @sistella
Expand Down