Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh-tw] localize 'DevOps' #2048

Merged
merged 1 commit into from
Jun 16, 2023
Merged

[zh-tw] localize 'DevOps' #2048

merged 1 commit into from
Jun 16, 2023

Conversation

roseyangwc
Copy link
Contributor

@roseyangwc roseyangwc commented May 16, 2023

Describe your changes

Add content/zh-tw/devops.md for 'DevOps' localization.
Original content: https://glossary.cncf.io/devops/

Related issue number or link (ex: resolves #issue-number)

#2045

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@roseyangwc roseyangwc requested review from pichuang and ydFu as code owners May 16, 2023 12:21
@netlify
Copy link

netlify bot commented May 16, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 4d831f3
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/647d5515b0ffa80008020e6a
😎 Deploy Preview https://deploy-preview-2048--cncfglossary.netlify.app/zh-tw/devops
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@roseyangwc roseyangwc force-pushed the dev-tw-devops branch 2 times, most recently from 535274c to 3ff90a5 Compare May 16, 2023 12:29
@ydFu ydFu added the lang/tw for Traditional Chinese label May 16, 2023
@ydFu ydFu linked an issue May 16, 2023 that may be closed by this pull request
content/zh-tw/devops.md Outdated Show resolved Hide resolved
content/zh-tw/devops.md Outdated Show resolved Hide resolved
content/zh-tw/devops.md Outdated Show resolved Hide resolved
content/zh-tw/devops.md Outdated Show resolved Hide resolved
@pichuang
Copy link
Contributor

@roseyangwc Could you please merge these 2 commits using the squash method into a single commit? and I will approve this. Thx

https://docs.github.com/en/desktop/contributing-and-collaborating-using-github-desktop/managing-commits/squashing-commits-in-github-desktop

@roseyangwc
Copy link
Contributor Author

@roseyangwc Could you please merge these 2 commits using the squash method into a single commit? and I will approve this. Thx

https://docs.github.com/en/desktop/contributing-and-collaborating-using-github-desktop/managing-commits/squashing-commits-in-github-desktop

Done.

Copy link
Contributor

@pichuang pichuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ydFu ydFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the style guide, one sentence per line is recommended, following the original.

https://glossary.cncf.io/style-guide/#three-subheadings

content/zh-tw/devops.md Outdated Show resolved Hide resolved
content/zh-tw/devops.md Outdated Show resolved Hide resolved
content/zh-tw/devops.md Outdated Show resolved Hide resolved
content/zh-tw/devops.md Outdated Show resolved Hide resolved
content/zh-tw/devops.md Outdated Show resolved Hide resolved
Signed-off-by: roseyang <roseyang@cpht.pro>

[zh-tw] Update content

1. Change the page links
2. Clearly and simply explain for the portmanteau

Signed-off-by: roseyang <roseyang@cpht.pro>

[zh-tw] revise contents and wording

1. Follow CNCF style guide
2. Revised according to suggestion & team discussion

Signed-off-by: roseyang <roseyang@cpht.pro>
@roseyangwc
Copy link
Contributor Author

Hi @ydFu ,

Please help check again, thanks!

Copy link
Collaborator

@ydFu ydFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roseyangwc
LGTM,thank you for your contribution.

@ydFu ydFu merged commit 2c73aa4 into cncf:dev-tw Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/tw for Traditional Chinese
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tw] Localize DevOps for Traditional Chinese
3 participants