-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[zh-tw] localize 'DevOps' #2048
Conversation
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
535274c
to
3ff90a5
Compare
@roseyangwc Could you please merge these 2 commits using the squash method into a single commit? and I will approve this. Thx |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the style guide, one sentence per line is recommended, following the original.
Signed-off-by: roseyang <roseyang@cpht.pro> [zh-tw] Update content 1. Change the page links 2. Clearly and simply explain for the portmanteau Signed-off-by: roseyang <roseyang@cpht.pro> [zh-tw] revise contents and wording 1. Follow CNCF style guide 2. Revised according to suggestion & team discussion Signed-off-by: roseyang <roseyang@cpht.pro>
Hi @ydFu , Please help check again, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roseyangwc
LGTM,thank you for your contribution.
Describe your changes
Add content/zh-tw/devops.md for 'DevOps' localization.
Original content: https://glossary.cncf.io/devops/
Related issue number or link (ex:
resolves #issue-number
)#2045
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.