-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EN] add eBPF #2050
[EN] add eBPF #2050
Conversation
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks, @MaryamTavakkoli. We are still working on pod and stateless apps. Next is runtime and then we'll tackle this PR . Thanks for your patience! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution and patience, @MaryamTavakkoli!
I reviewed the first section, made some light edits, moved one section up, and have a few questions.
9e964f0
to
e6568bc
Compare
@CathPag I applied all the suggestions, please have another look :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CathPag I made some edit suggestions to cover your comment about security risks. Let me know what you think.
@CathPag I see you have pushed the suggestions, thanks! Can you help me understand what is the next step? It shows some checks were not successful (un-signed commits) and some spell-checking. But both seem correct to me (all commits are signed and spells sound fine!), and I don't understand what is wrong. |
We need a technical reviewer to have a look as well. Unfortunately, we have a little bit of a backlog right now. But another round of reviews needed. As to the spellcheck error, eBPF needs to be added to the "wordlist.txt" file. You can find instructions here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @MaryamTavakkoli!
I've gone through and made some specific technical suggestions in line.
We should also consider mentioning other areas where eBPF is useful, like networking, observability, and security. I don't know if these are key to the definition, but they may provide more context around why eBPF is important.
@nate-double-u Thanks for the suggestions. I applied those suggestions now. Is this in good shape now or we should still add more content? |
Thanks for making the updates @MaryamTavakkoli! This looks good to me from a technical standpoint.
Thanks for the explanation @CathPag, it makes it easier to understand how the process works :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done with the 2nd part. I've got many questions, though, sorry, @MaryamTavakkoli! Since I'm non-technical, I serve as the "guinea pig" to ensure these definitions are understandable for that audience as well.
content/en/ebpf.md
Outdated
they send a request to the kernel. | ||
For applications that require more flexibility, such as direct hardware | ||
access, the kernel can be extended via what is known as the "Linux | ||
kernel modules" approach. This approach extends the kernel's default functionality |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: reading through "the problem it addresses" it seems like eBFP is not a "Linux kernel model", but an alternative...or am I getting this wrong? If so, we could probably say below: "However, this approach also introduces security risks making eBFP an attractive alternative."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied this as well.
Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com>
Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com>
Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com>
Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com>
Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com>
Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments. Suggestions seem to be correct.
Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com>
please @MaryamTavakkoli also check the spellcheck, there are words missing in the wordlist :) Thanks |
Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I made some minor edits, but this is a solid definition. If these look good to you, @MaryamTavakkoli, we can finalize the edit review and merge 🎉
...and thanks again for your patience while we were onboarding new reviewers and figuring out a new review process!
Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com>
Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com>
Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com>
Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com>
Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com>
Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com>
Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com>
Thanks for the great comments. I applied the suggestions and it seems fine to me to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finalizing
Signed-off-by: Noah Ispas <Noahispas@gmail.com>
Signed-off-by: Noah Ispas <Noahispas@gmail.com>
Signed-off-by: Noah Ispas <Noahispas@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so so much @MaryamTavakkoli for your contribution and for your patience while we finalized this new term. Also thanks to all maintainers involved :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* [EN] Add new term (eBPF) Resolves cncf#1448 Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> Signed-off-by: MaryamTavakkoli <maryam_tavakkoli@hotmail.com> * Update ebpf.md Added semantic line breaks Signed-off-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: MaryamTavakkoli <maryam_tavakkoli@hotmail.com> * Apply suggested editions Signed-off-by: MaryamTavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> Signed-off-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: MaryamTavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> Signed-off-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: MaryamTavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> Signed-off-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: MaryamTavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> Signed-off-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: MaryamTavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> Signed-off-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: MaryamTavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Nate W. <natew@cncf.io> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> Signed-off-by: MaryamTavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Nate W. <natew@cncf.io> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> Signed-off-by: MaryamTavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Nate W. <natew@cncf.io> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> Signed-off-by: MaryamTavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Nate W. <natew@cncf.io> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> Signed-off-by: MaryamTavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Nate W. <natew@cncf.io> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> Signed-off-by: MaryamTavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Nate W. <natew@cncf.io> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> Signed-off-by: MaryamTavakkoli <maryam_tavakkoli@hotmail.com> * Update wordlist.txt Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> Signed-off-by: MaryamTavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Noah Ispas <Noahispas@gmail.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> Signed-off-by: MaryamTavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Noah Ispas <Noahispas@gmail.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> Signed-off-by: MaryamTavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Noah Ispas <Noahispas@gmail.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> Signed-off-by: MaryamTavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Noah Ispas <Noahispas@gmail.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> Signed-off-by: MaryamTavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> * Update ebpf.md Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> * Update wordlist.txt Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> * Update content/en/ebpf.md Signed-off-by: Noah Ispas <Noahispas@gmail.com> * Update wordlist.txt Signed-off-by: Noah Ispas <Noahispas@gmail.com> * Update wordlist.txt Signed-off-by: Noah Ispas <Noahispas@gmail.com> --------- Signed-off-by: Maryam Tavakkoli <maryam_tavakkoli@hotmail.com> Signed-off-by: MaryamTavakkoli <maryam_tavakkoli@hotmail.com> Signed-off-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Noah Ispas <Noahispas@gmail.com> Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Co-authored-by: Nate W. <natew@cncf.io> Co-authored-by: Noah Ispas <Noahispas@gmail.com>
Describe your changes
Added a new term - eBPF
Related issue number or link (ex:
resolves #issue-number
)Resolves #1448
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.