Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EN] Update an existing term (GitOps) #2104

Closed
wants to merge 2 commits into from

Conversation

MaryamTavakkoli
Copy link
Contributor

@MaryamTavakkoli MaryamTavakkoli commented May 31, 2023

Describe your changes

Updated an existing term - GitOps

Related issue number or link (ex: resolves #issue-number)

Resolves #2073 and #372

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@netlify
Copy link

netlify bot commented May 31, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit eb896c1
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6485779a178e8a0008c172bc
😎 Deploy Preview https://deploy-preview-2104--cncfglossary.netlify.app/gitops
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the lang/en for English label May 31, 2023
@jihoon-seo
Copy link
Collaborator

@MaryamTavakkoli Thank you for your contribution!
But first, it is required that contributors sign off their commits with DCO signature.
You might achieve this by

And it seems that

  • the email address configured in your GitHub account, and
  • the email address of the commit author (which is from the email address you configured in your local dev env)

does not match.
I recommend you to align those as well, since this will make it easy and clear to identify the commit author's identity (in the form of GitHub account).

PTAL!

@CathPag
Copy link
Collaborator

CathPag commented Jun 9, 2023

...and could we please first finalize the eBFP PR? We generally don't allow contributors to start working on a new term before the other is finalized, so my apologies for that.

Signed-off-by: maryam.tavakkoli@relexsolutions.com <“maryam_tavakkoli@hotmain.com”>
Signed-off-by: maryam.tavakkoli@relexsolutions.com <“maryam_tavakkoli@hotmain.com”>
@MaryamTavakkoli
Copy link
Contributor Author

I opened another MR #2121 and I close this one.

1 similar comment
@MaryamTavakkoli
Copy link
Contributor Author

I opened another MR #2121 and I close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/en for English
Projects
None yet
Development

Successfully merging this pull request may close these issues.

version control & gitops
3 participants