Removing Catherine maintainer mentions #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
CathPag
requested review from
caniszczyk,
JasonMorgan,
seokho-son,
iamNoah1,
jihoon-seo,
nate-double-u and
castrojo
as code owners
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CathPag
changed the title
CathPag
added
the
maintainers
iamNoah1
approved these changes
Aug 2, 2023
|
@jihoon-seo @seokho-son don't we need to remove her also from the owners file(s)? |
2 tasks
7 tasks
I think so, but we can open a follow up issue. |
Signed-off-by: Nate W <natew@cncf.io>
|
It looks like #2343 takes care of the owners file. |
This was referenced Sep 7, 2023
Fionn88
pushed a commit
to Fionn88/glossary
that referenced
this pull request
Sep 15, 2023
* Removing Catherine as maintainer Signed-off-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> * how to Signed-off-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> * Update content/en/_index.md Signed-off-by: Nate W <natew@cncf.io> --------- Signed-off-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Nate W <natew@cncf.io> Co-authored-by: Nate W <natew@cncf.io>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Removing Catherine as maintainer mentions
Related issue number or link (ex:
resolves #issue-number)Checklist before opening this PR (put
xin the checkboxes)git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfigby runninggit config --global alias.ci "commit -s".