Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tw] Localize Virtualization for Traditional Chinese #2312

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

johnlinp
Copy link
Collaborator

Describe your changes

Origin content from https://glossary.cncf.io/virtualization/

Related issue number or link (ex: resolves #issue-number)

resolves #2310

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@johnlinp johnlinp requested review from pichuang and ydFu as code owners August 18, 2023 16:45
@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 112aa43
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/64e33ecdf78076000844d72a
😎 Deploy Preview https://deploy-preview-2312--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the lang/tw for Traditional Chinese label Aug 18, 2023
Copy link
Collaborator

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ydFu ydFu linked an issue Aug 19, 2023 that may be closed by this pull request
Copy link
Collaborator

@ydFu ydFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translate to '計算機' according this discussion to our preference

content/zh-tw/virtualization.md Outdated Show resolved Hide resolved
content/zh-tw/virtualization.md Outdated Show resolved Hide resolved
content/zh-tw/virtualization.md Outdated Show resolved Hide resolved
content/zh-tw/virtualization.md Outdated Show resolved Hide resolved
content/zh-tw/virtualization.md Outdated Show resolved Hide resolved
content/zh-tw/virtualization.md Outdated Show resolved Hide resolved
content/zh-tw/virtualization.md Outdated Show resolved Hide resolved
content/zh-tw/virtualization.md Outdated Show resolved Hide resolved
content/zh-tw/virtualization.md Outdated Show resolved Hide resolved
Signed-off-by: John Lin <johnlinp@gmail.com>
@johnlinp johnlinp force-pushed the dev-tw-virtualization branch from 409f898 to 112aa43 Compare August 21, 2023 10:39
@johnlinp
Copy link
Collaborator Author

johnlinp commented Aug 21, 2023

@ydFu @pichuang 我有接受你們的修改建議了,再麻煩你看看,謝謝。

@johnlinp johnlinp requested review from ydFu and pichuang August 21, 2023 10:42
Copy link
Contributor

@pichuang pichuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt

Copy link
Collaborator

@ydFu ydFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,thanks @johnlinp

@ydFu ydFu merged commit c4e7b17 into cncf:dev-tw Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/tw for Traditional Chinese
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tw] Localize Virtualization for Traditional Chinese
4 participants