Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[en] Add a link in cloud-native-tech.md #2471

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

shurup
Copy link
Collaborator

@shurup shurup commented Oct 6, 2023

Describe your changes

Since the style guide encourages links to existing glossary terms, I think linking to the Loosely Coupled Architecture will be helpful here.

Related issue number or link (ex: resolves #issue-number)

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Signed-off-by: Dmitry Shurupov <dmitry.shurupov@palark.com>
@netlify
Copy link

netlify bot commented Oct 6, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 9b4c06c
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/651fe9c373864f0008f953d7
😎 Deploy Preview https://deploy-preview-2471--cncfglossary.netlify.app/cloud-native-tech
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the lang/en for English label Oct 6, 2023
Copy link
Contributor

@justankiit justankiit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for the update @shurup

@nate-double-u nate-double-u merged commit f1c7483 into cncf:main Dec 4, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/en for English
Projects
Development

Successfully merging this pull request may close these issues.

4 participants