Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tw] Remove what-it-is header from all TW docs #2664

Closed
wants to merge 1 commit into from
Closed

[tw] Remove what-it-is header from all TW docs #2664

wants to merge 1 commit into from

Conversation

tico88612
Copy link
Collaborator

Describe your changes

Related issue number or link (ex: resolves #issue-number)

resolves #2662

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@netlify Netlify
Copy link

netlify bot commented Dec 2, 2023 •
edited
Loading

✅ Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit a5a4fc4
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/656bdefe0a85bd00085c348e
😎 Deploy Preview https://deploy-preview-2664--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the lang/tw for Traditional Chinese label Dec 2, 2023
johnlinp
johnlinp approved these changes Dec 2, 2023
View reviewed changes
Copy link
Collaborator

@johnlinp johnlinp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tico88612
remove: what-it-is header from all TW docs
a5a4fc4 
Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
@tico88612 tico88612 force-pushed the feat/tw-remove-what-is-it branch from b21f2b4 to a5a4fc4 Compare December 3, 2023 01:50
@tico88612 tico88612 requested a review from johnlinp December 3, 2023 02:13
johnlinp
johnlinp approved these changes Dec 3, 2023
View reviewed changes
Copy link
Collaborator

@johnlinp johnlinp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感謝!

ydFu
ydFu requested changes Dec 3, 2023
View reviewed changes
Copy link
Collaborator

@ydFu ydFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Large-scale file changes need to be confirmed one by one to see if there are other updates.

@tico88612
Copy link
Collaborator Author

tico88612 commented Dec 3, 2023 •
edited
Loading

Large-scale file changes need to be confirmed one by one to see if there are other updates.

You can visit this page (Last commit message) to help you check faster.

https://github.com/tico88612/glossary/tree/feat/tw-remove-what-is-it/content/zh-tw

@johnlinp
Copy link
Collaborator

johnlinp commented Dec 3, 2023

@tico88612 哈囉，我想 @ydFu 的意思是說，當我們在修改多個檔案的內容時，我們會需要確認英文版的內容有沒有在這期間被更新。我想這樣是為了避免到時候編輯的時序錯亂，造成之後更新的困難。

但我剛剛掃了一下，看起來你的檔案都已經跟到英文版的最新版了，所以我覺得這部份應該是沒問題的，謝謝。

pichuang
pichuang approved these changes Dec 3, 2023
View reviewed changes
Copy link
Contributor

@pichuang pichuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed and thx

@jihoon-seo jihoon-seo linked an issue Dec 4, 2023 that may be closed by this pull request
[tw] Remove "What it is" section #2662
Open
45 tasks
hwchiu
hwchiu approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ydFu
ydFu reviewed Dec 5, 2023
View reviewed changes
content/zh-tw/_TEMPLATE.md
@@ -4,8 +4,6 @@ status: Feedback Appreciated
category: 概念
---

## 是什麼 {#what-it-is}

快速總結概念及其意義。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
快速總結概念及其意義。
快速總結概念。

Miss this change

#2652

content/zh-tw/style-guide/_index.md
@@ -49,8 +49,6 @@ status:
category:
---

## 是什麼

對該技術或概念的快速總結。

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Miss this change.

https://github.com/cncf/glossary/pull/2652/files#diff-f0035a3662384e762cfe06bd4661211988eae9f632b7e5ab740ef932a16df1acR82

content/zh-tw/cloud-native-tech.md
@@ -5,8 +5,6 @@ category: 概念
tags: ["基本原理", "", ""]
---

## 什麼是雲端原生技術 {#what-it-is}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

miss this change

#2471

@ydFu
Copy link
Collaborator

ydFu commented Dec 5, 2023 •
edited
Loading

@tico88612 哈囉，我想 @ydFu 的意思是說，當我們在修改多個檔案的內容時，我們會需要確認英文版的內容有沒有在這期間被更新。我想這樣是為了避免到時候編輯的時序錯亂，造成之後更新的困難。

但我剛剛掃了一下，看起來你的檔案都已經跟到英文版的最新版了，所以我覺得這部份應該是沒問題的，謝謝。

誠如上述所敘，在進行詳盡補充，
英文內容可以大量檔案相關異動更新
與本地化語系內容大量檔案不適合有相關異動更新，
最大的差別是本地化內容同時可能會有多個其他相關更新，
並不只侷限於這個單一異動。

從Approver的審核視角，多半已會依照上次更新內容與您提供的相關PR review，
如果沒有檢查到或是miss掉就會發生本地化與英文內容越來越脫鉤的議題，
你仔細觀察本專案中簡體中文就有這種問題。

而從本PR就我部份review的內容就有發現3個以上沒有被更新到，
其他有沒有相關沒有被更新到的問題，一次44個檔案也無法進行保證。

建議本次更新不需要再一個PR中就完成，
可以在一個issue開多個子任務分批完成，
因此為了保有長期可維護性的原因關閉此PR。

@ydFu ydFu closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ydFu ydFu ydFu requested changes

@pichuang pichuang pichuang approved these changes

@hwchiu hwchiu hwchiu approved these changes

@johnlinp johnlinp johnlinp approved these changes

Assignees
No one assigned
Labels
lang/tw for Traditional Chinese
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tw] Remove "What it is" section
5 participants
@tico88612 @johnlinp @ydFu @hwchiu @pichuang