Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove what it is header from all En docs #2652

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Conversation

seokho-son
Copy link
Collaborator

Describe your changes

fix #2575

Related issue number or link (ex: resolves #issue-number)

#2575
#2242

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Signed-off-by: Seokho Son <shsongist@gmail.com>
Copy link

netlify bot commented Nov 29, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit e57ed31
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/65682fb6feae1c0008ada216
😎 Deploy Preview https://deploy-preview-2652--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the lang/en for English label Nov 29, 2023
@seokho-son seokho-son added the maintainers Use this label if PR requires maintainers to take action label Nov 29, 2023
Copy link

To see where this is in the review pipeline and follow the progress, please look at the definition review board.

@seokho-son
Copy link
Collaborator Author

Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for doing this @seokho-son! I have a couple of comments, but don't let these be blockers if you'd like to merge as is.


Quick summary of the concept and what it is.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably leave the "and what it is" line here as this is a section that is now the introduction.

@@ -48,7 +48,6 @@ status:
category:
---

## What it is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove one more blank line here too

Signed-off-by: Seokho Son <shsongist@gmail.com>
@seokho-son
Copy link
Collaborator Author

@nate-double-u Thanks for the review :)
I applied all your suggestions. ;)

Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and thanks a bunch for the efforts

@iamNoah1 iamNoah1 merged commit f81164b into cncf:main Nov 30, 2023
5 checks passed
@nate-double-u nate-double-u mentioned this pull request Dec 1, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/en for English maintainers Use this label if PR requires maintainers to take action
Projects
Development

Successfully merging this pull request may close these issues.

Remove the What it is Header completely
3 participants