-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove what it is header from all En docs #2652
Conversation
Signed-off-by: Seokho Son <shsongist@gmail.com>
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
To see where this is in the review pipeline and follow the progress, please look at the definition review board. |
preview example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for doing this @seokho-son! I have a couple of comments, but don't let these be blockers if you'd like to merge as is.
|
||
Quick summary of the concept and what it is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably leave the "and what it is" line here as this is a section that is now the introduction.
@@ -48,7 +48,6 @@ status: | |||
category: | |||
--- | |||
|
|||
## What it is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's remove one more blank line here too
Signed-off-by: Seokho Son <shsongist@gmail.com>
@nate-double-u Thanks for the review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm and thanks a bunch for the efforts
Describe your changes
fix #2575
Related issue number or link (ex:
resolves #issue-number
)#2575
#2242
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.