Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tw] Localize Scalability for Traditional Chinese #2498

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Conversation

win5923
Copy link
Contributor

@win5923 win5923 commented Oct 13, 2023

Describe your changes

Origin content from https://glossary.cncf.io/scalability/

Related issue number or link (ex: resolves #issue-number)

resolves #2491

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@netlify
Copy link

netlify bot commented Oct 13, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 6559a0d
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/653365aa5c387b00088c8329
😎 Deploy Preview https://deploy-preview-2498--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the lang/tw for Traditional Chinese label Oct 13, 2023
content/zh-tw/scalability.md Outdated Show resolved Hide resolved
content/zh-tw/scalability.md Outdated Show resolved Hide resolved
content/zh-tw/scalability.md Show resolved Hide resolved
content/zh-tw/scalability.md Outdated Show resolved Hide resolved
@win5923 win5923 force-pushed the dev-tw branch 6 times, most recently from 90c5dc7 to 3cbe672 Compare October 14, 2023 15:23
Copy link
Collaborator

@johnlinp johnlinp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

謝謝!

content/zh-tw/scalability.md Outdated Show resolved Hide resolved
content/zh-tw/scalability.md Show resolved Hide resolved
content/zh-tw/scalability.md Outdated Show resolved Hide resolved
content/zh-tw/scalability.md Outdated Show resolved Hide resolved
@win5923 win5923 force-pushed the dev-tw branch 2 times, most recently from 455f63a to 4d74650 Compare October 19, 2023 15:55
@ydFu ydFu linked an issue Oct 20, 2023 that may be closed by this pull request
Copy link
Collaborator

@ydFu ydFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole thing looks good. After modifying the quantifiers, I compressed multiple git commits into one. I can merge this PR. If you don’t know how to compress git commits, you can ask in slack.

content/zh-tw/scalability.md Outdated Show resolved Hide resolved
content/zh-tw/scalability.md Outdated Show resolved Hide resolved
@win5923 win5923 force-pushed the dev-tw branch 3 times, most recently from 2e05000 to 5e37df2 Compare October 20, 2023 02:31
@ydFu
Copy link
Collaborator

ydFu commented Oct 20, 2023

It seems that the change has been changed to other documents. Check the commit to be contributed.

image

https://github.com/cncf/glossary/compare/2e050009cfbd60c911f9e4ad740c429412bb11af..5e37df2ce54faaeca09839a989ff954c8ebb54f4

@win5923
Copy link
Contributor Author

win5923 commented Oct 20, 2023

Sorry, I forgot to merge it.

Copy link
Collaborator

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

麻煩 rebase 一下變成 1 筆 commit,剩下沒問題就可以合併了

感謝

Signed-off-by: win5923 <ken89@kimo.com>
Copy link
Collaborator

@ydFu ydFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwchiu hwchiu merged commit d7aae95 into cncf:dev-tw Oct 28, 2023
4 checks passed
@win5923 win5923 deleted the dev-tw branch December 15, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/tw for Traditional Chinese
Projects
Development

Successfully merging this pull request may close these issues.

[tw] Localize Scalability for Traditional Chinese
4 participants