[hi] Localize security-chaos-engineering.md #2608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abhay-raj19 <rajpootabhay423@gmail.com>
abhay-raj19
requested review from
Garima-Negi,
jayesh-srivastava,
aj11anuj,
justankiit and
bishal7679
as code owners
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
justankiit
reviewed
Nov 12, 2023
bishal7679
reviewed
Nov 12, 2023
6 tasks
|
@bishal7679 now check up on those changes, have corrected them . |
bishal7679
changed the title
|
Pls do review up the changes if you are satisfied with the changes do approve the request from your end @bishal7679 |
bishal7679
requested changes
Nov 15, 2023
| ## यह क्या है | ||
|
|
||
|
|
||
| सुरक्षा अव्यवस्था इंजीनियरिंग(SCE) एक ऐसी शाखा है जो की [सीमावर्ती प्रणाली](/chaos-engineering/) पर आधारित है। |
There was a problem hiding this comment.
Suggested change
| सुरक्षा अव्यवस्था इंजीनियरिंग(SCE) एक ऐसी शाखा है जो की [सीमावर्ती प्रणाली](/chaos-engineering/) पर आधारित है। | |
| सुरक्षा अव्यवस्था इंजीनियरिंग(SCE) एक ऐसी शाखा है जो की [अव्यवस्था इंजीनियरिंग](/chaos-engineering/) पर आधारित है। |
|
@kumarankit999 @bishal7679 @aj11anuj @jayesh-srivastava , made the changes as suggested now review it |
justankiit
reviewed
Nov 16, 2023
justankiit
reviewed
Nov 16, 2023
|
pls remove L23 and squash all the commits |
|
now fixed the suggested changes pls do check from your end @kumarankit999 @bishal7679 |
bishal7679
approved these changes
Nov 17, 2023
|
Approver while merging make sure to apply squash and merge! |
justankiit
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by : abhay-raj19 rajpootabhay423@gmail.com
Describe your changes
Localised a security chaos engineering document in hindi.
Ref: #2057
As this PR was being successfully reviewed by @jayesh-srivastava and was waiting for second Reviewer.
But due to some changes from my end this PR got deleted suddenly.
And re-open feature was not being available from my end .
Related issue number or link (ex:
resolves #issue-number)#1986
Checklist before opening this PR (put
xin the checkboxes)git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfigby runninggit config --global alias.ci "commit -s".