-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ja] tralslate abstraction.md into japanese #2727
Conversation
translate ja lang/ja Signed-off-by: kujiraitakahiro <takahiro.kujirai@it.zeus-enterprise.co.jp>
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
f3131b5
to
5f76053
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DCOをはじめ、何かがおかしくなってしまった。。。
DCOに関しては、CIのDetails に書いてあるとおり、手元で $ git checkout <your-branch>
$ git rebase HEAD~8 --signoff
$ git push --force-with-lease origin dev-ja などを叩くと解消できますかね。。?? Netlifyのビルドやdeploy-previewが失敗しているのは、以下の箇所のダブルクオテーションが抜けているのが原因かもしれないです(手元で検証していないので確証はないですが。。) glossary/content/ja/abstraction.md Line 5 in 01d6c52
|
Co-authored-by: Kaito Ii <kaitoii1111@gmail.com> Signed-off-by: kujiraitakahiro <takahiro.kujirai@it.zeus-enterprise.co.jp>
Co-authored-by: Kaito Ii <kaitoii1111@gmail.com> Signed-off-by: kujiraitakahiro <takahiro.kujirai@it.zeus-enterprise.co.jp>
Co-authored-by: Kaito Ii <kaitoii1111@gmail.com> Signed-off-by: kujiraitakahiro <takahiro.kujirai@it.zeus-enterprise.co.jp>
This reverts commit 2b490f2. Signed-off-by: kujiraitakahiro <takahiro.kujirai@it.zeus-enterprise.co.jp>
Signed-off-by: kujiraitakahiro <takahiro.kujirai@it.zeus-enterprise.co.jp>
This reverts commit b364cf9. Signed-off-by: kujiraitakahiro <takahiro.kujirai@it.zeus-enterprise.co.jp>
This reverts commit 079ba19. Signed-off-by: kujiraitakahiro <takahiro.kujirai@it.zeus-enterprise.co.jp>
Signed-off-by: kujiraitakahiro <takahiro.kujirai@it.zeus-enterprise.co.jp>
89c7630
to
d104932
Compare
@Okabe-Junya DCO、OK & やはり " がなくてこけていたようです。 |
content/ja/abstraction.md
Outdated
|
||
通常、システムには複数の抽象化レイヤーがあります。 | ||
これにより、開発が大幅に簡素化されます。 | ||
プログラミングの際、開発者は特定の抽象化レイヤーと互換性のあるコンポーネントを構築するため、非常に異質な可能性があるすべての基礎となる詳細について心配する必要はありません。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
抽象化レイヤーに言及しているので、underleyingは「基礎」よりも「下層レイヤー」や「下部のレイヤー」の方がわかりやすいと思いました。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naonishijima
tags: ["基礎(下層レイヤー)", "", ""]
こんな感じだといいんですかね?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tagの部分ではなく、「すべての基礎となる詳細について〜」の部分です。「全ての下層レイヤーの詳細について〜」や「全ての下部レイヤーの詳細について〜」です。
Signed-off-by: kujiraitakahiro <takahiro.kujirai@it.zeus-enterprise.co.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(このPRのreviewerにはなっていないですが)先ほど確認したらreviewerが1名足りていなさそうだったので、自分がレビューしてしまいます 🙏
遅くなって申し訳ないです
(naoさんへのre-reviewが飛んでいなさそうなので、自分の方から送ってしまいます) |
friendly ping @kujiraitakahiro もしよければ修正して、PRマージできるようにしていただけると嬉しいです〜! |
Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com> Signed-off-by: kujiraitakahiro <takahiro.kujirai@it.zeus-enterprise.co.jp>
Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com> Signed-off-by: kujiraitakahiro <takahiro.kujirai@it.zeus-enterprise.co.jp>
@Okabe-Junya |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ご対応ありがとうございます〜!LGTMです
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
translate ja
lang/ja
Describe your changes
Related issue number or link (ex: resolves #issue-number)
Checklist before opening this PR (put x in the checkboxes)
git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.