Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] tralslate abstraction.md into japanese #2727

Merged
merged 12 commits into from
Mar 18, 2024

Conversation

kujiraitakahiro
Copy link
Contributor

translate ja
lang/ja
Describe your changes
Related issue number or link (ex: resolves #issue-number)
Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

translate ja
lang/ja

Signed-off-by: kujiraitakahiro <takahiro.kujirai@it.zeus-enterprise.co.jp>
Copy link

netlify bot commented Dec 17, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit a2ae45e
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/65f7d082d458a7000767b307
😎 Deploy Preview https://deploy-preview-2727--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor Author

@kujiraitakahiro kujiraitakahiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DCOをはじめ、何かがおかしくなってしまった。。。

@Okabe-Junya
Copy link
Collaborator

Okabe-Junya commented Dec 17, 2023

DCOに関しては、CIのDetails に書いてあるとおり、手元で

$ git checkout <your-branch>
$ git rebase HEAD~8 --signoff
$ git push --force-with-lease origin dev-ja

などを叩くと解消できますかね。。??

Netlifyのビルドやdeploy-previewが失敗しているのは、以下の箇所のダブルクオテーションが抜けているのが原因かもしれないです(手元で検証していないので確証はないですが。。)

tags: ["基礎, "", ""]

kujiraitakahiro and others added 8 commits December 17, 2023 21:04
Co-authored-by: Kaito Ii <kaitoii1111@gmail.com>
Signed-off-by: kujiraitakahiro <takahiro.kujirai@it.zeus-enterprise.co.jp>
Co-authored-by: Kaito Ii <kaitoii1111@gmail.com>
Signed-off-by: kujiraitakahiro <takahiro.kujirai@it.zeus-enterprise.co.jp>
Co-authored-by: Kaito Ii <kaitoii1111@gmail.com>
Signed-off-by: kujiraitakahiro <takahiro.kujirai@it.zeus-enterprise.co.jp>
This reverts commit 2b490f2.

Signed-off-by: kujiraitakahiro <takahiro.kujirai@it.zeus-enterprise.co.jp>
Signed-off-by: kujiraitakahiro <takahiro.kujirai@it.zeus-enterprise.co.jp>
This reverts commit b364cf9.

Signed-off-by: kujiraitakahiro <takahiro.kujirai@it.zeus-enterprise.co.jp>
This reverts commit 079ba19.

Signed-off-by: kujiraitakahiro <takahiro.kujirai@it.zeus-enterprise.co.jp>
Signed-off-by: kujiraitakahiro <takahiro.kujirai@it.zeus-enterprise.co.jp>
@kujiraitakahiro
Copy link
Contributor Author

@Okabe-Junya
ありがとうございます!

DCO、OK & やはり " がなくてこけていたようです。


通常、システムには複数の抽象化レイヤーがあります。
これにより、開発が大幅に簡素化されます。
プログラミングの際、開発者は特定の抽象化レイヤーと互換性のあるコンポーネントを構築するため、非常に異質な可能性があるすべての基礎となる詳細について心配する必要はありません。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

抽象化レイヤーに言及しているので、underleyingは「基礎」よりも「下層レイヤー」や「下部のレイヤー」の方がわかりやすいと思いました。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naonishijima
tags: ["基礎(下層レイヤー)", "", ""]
こんな感じだといいんですかね?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tagの部分ではなく、「すべての基礎となる詳細について〜」の部分です。「全ての下層レイヤーの詳細について〜」や「全ての下部レイヤーの詳細について〜」です。

Signed-off-by: kujiraitakahiro <takahiro.kujirai@it.zeus-enterprise.co.jp>
Copy link
Collaborator

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(このPRのreviewerにはなっていないですが)先ほど確認したらreviewerが1名足りていなさそうだったので、自分がレビューしてしまいます 🙏

遅くなって申し訳ないです

content/ja/abstraction.md Outdated Show resolved Hide resolved
content/ja/abstraction.md Show resolved Hide resolved
content/ja/abstraction.md Outdated Show resolved Hide resolved
@Okabe-Junya
Copy link
Collaborator

Okabe-Junya commented Jan 26, 2024

(naoさんへのre-reviewが飛んでいなさそうなので、自分の方から送ってしまいます)

@Okabe-Junya
Copy link
Collaborator

friendly ping @kujiraitakahiro

もしよければ修正して、PRマージできるようにしていただけると嬉しいです〜!

kujiraitakahiro and others added 2 commits March 18, 2024 14:26
Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>
Signed-off-by: kujiraitakahiro <takahiro.kujirai@it.zeus-enterprise.co.jp>
Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>
Signed-off-by: kujiraitakahiro <takahiro.kujirai@it.zeus-enterprise.co.jp>
@kujiraitakahiro
Copy link
Contributor Author

@Okabe-Junya
ありがとうございます。
対応しました。

Copy link
Collaborator

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ご対応ありがとうございます〜!LGTMです

@Okabe-Junya
Copy link
Collaborator

cc @naonishijima

Copy link
Collaborator

@naonishijima naonishijima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naonishijima naonishijima merged commit 8f84e41 into cncf:dev-ja Mar 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/ja for Japanese
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants