Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] Localize Service Proxy into Japanese #2898

Merged
merged 2 commits into from
Feb 17, 2024
Merged

Conversation

Okabe-Junya
Copy link
Collaborator

@Okabe-Junya Okabe-Junya commented Feb 5, 2024

Describe your changes

Localize Service Proxy into Japanese

Related issue number or link (ex: resolves #issue-number)

resolves #2769

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@Okabe-Junya Okabe-Junya self-assigned this Feb 5, 2024
Copy link

netlify bot commented Feb 5, 2024

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit b5f0118
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/65d0ae021fc9c0000849eec5
😎 Deploy Preview https://deploy-preview-2898--cncfglossary.netlify.app/ja/service-proxy
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the lang/ja for Japanese label Feb 5, 2024
Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
@Okabe-Junya Okabe-Junya linked an issue Feb 5, 2024 that may be closed by this pull request
@Okabe-Junya
Copy link
Collaborator Author

The target page on the deploy preview site:

@Okabe-Junya Okabe-Junya marked this pull request as ready for review February 9, 2024 07:00
@Okabe-Junya Okabe-Junya added the hold Wait, please do not proceed this yet label Feb 9, 2024
Copy link

github-actions bot commented Feb 9, 2024

Wait, please do not proceed with this yet.

@Okabe-Junya
Copy link
Collaborator Author

feel free to remove hold after #2872 will merge

Copy link
Collaborator

@naonishijima naonishijima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Okabe-Junya Okabe-Junya removed the hold Wait, please do not proceed this yet label Feb 14, 2024
Comment on lines 26 to 27
プロキシは重要なデータを収集し、ルーティングを管理します。
また(トラフィックをサービス間で均等に分散させたり、一部のサービスが故障した場合には再ルーティングしたり)、接続を暗号化し、コンテンツをキャッシュします(リソース消費を減らします)。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

訳としては原文通りですが、日本語として1つめの括弧は違和感がありますね。

プロキシは重要なデータを収集し、ルーティングを管理します(トラフィックをサービス間で均等に分散させたり、一部のサービスが故障した場合には再ルーティングしたり)。
また、接続を暗号化し、コンテンツをキャッシュします(リソース消費を減らします)。

こんな感じで位置をずらすのはどうでしょう。

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こんな感じで位置をずらすのはどうでしょう。

ありがとうございます。確かに、

(spreading ... down)

の箇所は、"manage routing" を補足しているので、括弧の位置があまり良くなかったですね。b5f0118 で修正しました :)

Signed-off-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>
Copy link
Collaborator

@kaitoii11 kaitoii11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaitoii11 kaitoii11 merged commit 59338a1 into cncf:dev-ja Feb 17, 2024
5 checks passed
@Okabe-Junya Okabe-Junya deleted the fix-2769 branch February 17, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/ja for Japanese
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ja] Localize Service Proxy for Japanese
3 participants