-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ja] Localize Service Proxy into Japanese #2898
Conversation
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
The target page on the deploy preview site: |
Wait, please do not proceed with this yet. |
feel free to remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
content/ja/service-proxy.md
Outdated
プロキシは重要なデータを収集し、ルーティングを管理します。 | ||
また(トラフィックをサービス間で均等に分散させたり、一部のサービスが故障した場合には再ルーティングしたり)、接続を暗号化し、コンテンツをキャッシュします(リソース消費を減らします)。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
訳としては原文通りですが、日本語として1つめの括弧は違和感がありますね。
プロキシは重要なデータを収集し、ルーティングを管理します(トラフィックをサービス間で均等に分散させたり、一部のサービスが故障した場合には再ルーティングしたり)。
また、接続を暗号化し、コンテンツをキャッシュします(リソース消費を減らします)。
こんな感じで位置をずらすのはどうでしょう。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
こんな感じで位置をずらすのはどうでしょう。
ありがとうございます。確かに、
(spreading ... down)
の箇所は、"manage routing" を補足しているので、括弧の位置があまり良くなかったですね。b5f0118 で修正しました :)
Signed-off-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Describe your changes
Localize Service Proxy into Japanese
Related issue number or link (ex:
resolves #issue-number
)resolves #2769
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.