Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update term] Ingress for Japanese #2917

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

Okabe-Junya
Copy link
Collaborator

@Okabe-Junya Okabe-Junya commented Feb 10, 2024

Describe your changes

Related issue number or link (ex: resolves #issue-number)

resolves #2914

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
Copy link

netlify bot commented Feb 10, 2024

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 31ae37f
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/65c79a7b871b20000892edac
😎 Deploy Preview https://deploy-preview-2917--cncfglossary.netlify.app/ja/ingress
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the lang/ja for Japanese label Feb 10, 2024
@Okabe-Junya Okabe-Junya self-assigned this Feb 10, 2024
@Okabe-Junya Okabe-Junya linked an issue Feb 10, 2024 that may be closed by this pull request
Copy link
Collaborator

@naonishijima naonishijima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Okabe-Junya Okabe-Junya added the hold Wait, please do not proceed this yet label Feb 11, 2024
Copy link

Wait, please do not proceed with this yet.

@Okabe-Junya
Copy link
Collaborator Author

feel free to remove hold after #2872 will merge

Copy link
Collaborator

@kaitoii11 kaitoii11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Okabe-Junya Okabe-Junya removed the hold Wait, please do not proceed this yet label Feb 12, 2024
@Okabe-Junya Okabe-Junya merged commit 2bfeefa into cncf:dev-ja Feb 12, 2024
8 checks passed
@Okabe-Junya Okabe-Junya deleted the fix-2914 branch February 12, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/ja for Japanese
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Update term] Ingress for Japanese
3 participants