-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EN] update term ingress #2904
[EN] update term ingress #2904
Conversation
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @seb-835
Signed-off-by: Asem Hamid <155321064+asem-hamid@users.noreply.github.com> Signed-off-by: Sebastien Aucouturier <sebastien.aucouturier@gmail.com>
…f#2874) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Sebastien Aucouturier <sebastien.aucouturier@gmail.com>
Signed-off-by: Sebastien Aucouturier <sebastien.aucouturier@gmail.com>
To see where this is in the review pipeline and follow the progress, please look at the definition review board. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @seb-835
/lgtm
Describe your changes
Update Term Ingress
Related issue number or link (ex:
resolves #issue-number
)resolves #2880 #2881
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.