[tr] Changing one of the approvers #2946
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Halil Bugol <halil@kubezy.com>
halil-bugol
requested review from
caniszczyk,
seokho-son,
iamNoah1,
jihoon-seo and
nate-double-u
as code owners
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Halil Bugol <halil@kubezy.com>
|
@halil-bugol thanks a lot for the PR. We, as the Turkish localiation team, appreciate all the efforts you've done so far. Thank you! As a final step, could you please fix the DCO? You need to do this and push again afterwards: |
Signed-off-by: Halil İbrahim BUGÖL <halil@kubezy.com>
jihoon-seo
added
maintainers
|
@halil-bugol can you fix the DCO issue? Basically, you need to sign off your commit. |
|
Created #3016 in favor of this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
My work is very busy and I cannot spare time here. It would be better for @symys to be the approver instead.
Related issue number or link (ex:
resolves #issue-number)Checklist before opening this PR (put
xin the checkboxes)git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfigby runninggit config --global alias.ci "commit -s".