-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tr] Replace a Turkish approver #3016
Conversation
Signed-off-by: Ali Ok <aliok@redhat.com>
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Created in favor of #2946 cc @halil-bugol @symys @rwxdash @eminalemdar Thanks Halil for all the work so far! |
cc @seokho-son @iamNoah1 |
/content/tr/ @aliok @halil-bugol @rwxdash @eminalemdar | ||
/i18n/tr.toml @aliok @halil-bugol @rwxdash @eminalemdar | ||
/content/tr/ @aliok @symys @rwxdash @eminalemdar | ||
/i18n/tr.toml @aliok @symys @rwxdash @eminalemdar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a warning about write access here, we might need someone to update the permissions for @symys
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its ok, I often saw this and it should be solved as soon as we have it merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Hi folks ! :)
Hi @symys please check #723 and let us know you've read and understood it. @halil-bugol thanks for your contributions as an approver so far ! |
Thanks. I am always here. :) @seokho-son |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all your work @halil-bugol, and welcome @symys!
Wait, please do not proceed with this yet. |
Adding hold label to give @symys a chance to confirm as per @seokho-son's post, and to make sure we've got the cncf/people PR correctly merged in. |
friendly reminder @symys @seokho-son. |
ok I saw @symys agreed, @seokho-son what is the status of cncf people PR? |
|
Lets merge this then :) welcome @symys |
Thank you so much :) |
Describe your changes
In favor of #2946
Related issue number or link (ex:
resolves #issue-number
)Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.