Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tr] Replace a Turkish approver #3016

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

aliok
Copy link
Member

@aliok aliok commented Mar 28, 2024

Describe your changes

In favor of #2946

Related issue number or link (ex: resolves #issue-number)

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Signed-off-by: Ali Ok <aliok@redhat.com>
Copy link

netlify bot commented Mar 28, 2024

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit d43bf58
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/66051d734a57db0008ba2c11
😎 Deploy Preview https://deploy-preview-3016--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aliok
Copy link
Member Author

aliok commented Mar 28, 2024

Created in favor of #2946

cc @halil-bugol @symys @rwxdash @eminalemdar

Thanks Halil for all the work so far!

@aliok
Copy link
Member Author

aliok commented Mar 28, 2024

cc @seokho-son @iamNoah1
We need your approval in this PR

@aliok aliok added maintainers Use this label if PR requires maintainers to take action lang/tr for Turkish labels Mar 28, 2024
/content/tr/ @aliok @halil-bugol @rwxdash @eminalemdar
/i18n/tr.toml @aliok @halil-bugol @rwxdash @eminalemdar
/content/tr/ @aliok @symys @rwxdash @eminalemdar
/i18n/tr.toml @aliok @symys @rwxdash @eminalemdar
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a warning about write access here, we might need someone to update the permissions for @symys.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its ok, I often saw this and it should be solved as soon as we have it merged.

Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seokho-son
Copy link
Collaborator

Hi folks ! :)

Hi @symys please check #723 and let us know you've read and understood it.
In the meantime, I am going to open a PR to https://github.com/cncf/people to get appropriate permission.

@halil-bugol thanks for your contributions as an approver so far !
Hope you can continue contributions regardless of the role. :)

@halil-bugol
Copy link

Thanks. I am always here. :) @seokho-son

Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all your work @halil-bugol, and welcome @symys!

@nate-double-u nate-double-u added the hold Wait, please do not proceed this yet label Apr 3, 2024
Copy link

github-actions bot commented Apr 3, 2024

Wait, please do not proceed with this yet.

@nate-double-u
Copy link
Member

Adding hold label to give @symys a chance to confirm as per @seokho-son's post, and to make sure we've got the cncf/people PR correctly merged in.

@iamNoah1
Copy link
Collaborator

friendly reminder @symys @seokho-son.

@iamNoah1
Copy link
Collaborator

ok I saw @symys agreed, @seokho-son what is the status of cncf people PR?

@seokho-son
Copy link
Collaborator

@seokho-son
Copy link
Collaborator

@iamNoah1
Copy link
Collaborator

Lets merge this then :) welcome @symys

@iamNoah1 iamNoah1 merged commit 74e2e88 into cncf:main Apr 16, 2024
10 checks passed
@symys
Copy link
Collaborator

symys commented Apr 16, 2024

Lets merge this then :) welcome @symys

Thank you so much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold Wait, please do not proceed this yet lang/tr for Turkish maintainers Use this label if PR requires maintainers to take action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants