-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ja] Localize Event Streaming into Japanese #3033
[ja] Localize Event Streaming into Japanese #3033
Conversation
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Kazunori Otani <kotani@splunk.com>
Signed-off-by: Kazunori Otani <kotani@splunk.com>
517a6ba
to
43a6386
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
継続的な貢献ありがとうございます!
Almost LGTMですが、一点だけ細かな修正をお願いいたします
Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com> Signed-off-by: Kazunori Otani <katzchang@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMです!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Describe your changes
Localize https://glossary.cncf.io/event-streaming/ into Japanese
Related issue number or link (ex:
resolves #issue-number
)Resolves #2854
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.