Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] Localize Event Streaming into Japanese #3033

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

katzchang
Copy link
Contributor

Describe your changes

Localize https://glossary.cncf.io/event-streaming/ into Japanese

Related issue number or link (ex: resolves #issue-number)

Resolves #2854

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@katzchang katzchang changed the base branch from main to dev-ja April 5, 2024 12:36
@github-actions github-actions bot added the lang/ja for Japanese label Apr 5, 2024
Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 1ba1482
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/66110bd2f97346000861a28c
😎 Deploy Preview https://deploy-preview-3033--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Kazunori Otani <kotani@splunk.com>
Signed-off-by: Kazunori Otani <kotani@splunk.com>
@katzchang katzchang force-pushed the ja-localize-event-streaming branch from 517a6ba to 43a6386 Compare April 5, 2024 12:38
Copy link
Collaborator

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

継続的な貢献ありがとうございます!

Almost LGTMですが、一点だけ細かな修正をお願いいたします

content/ja/event-streaming.md Outdated Show resolved Hide resolved
Co-authored-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>
Signed-off-by: Kazunori Otani <katzchang@gmail.com>
Copy link
Collaborator

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!

@Okabe-Junya Okabe-Junya mentioned this pull request Apr 6, 2024
2 tasks
Copy link
Collaborator

@naonishijima naonishijima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naonishijima naonishijima merged commit 62ec087 into cncf:dev-ja Apr 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/ja for Japanese
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ja] Localize Event Streaming into Japanese
3 participants