Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate content/pt/auto_scaling.md to portuguese #443

Merged
merged 20 commits into from
Apr 13, 2022
Merged

Translate content/pt/auto_scaling.md to portuguese #443

merged 20 commits into from
Apr 13, 2022

Conversation

matheuspaesp
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Feb 15, 2022 •
edited
Loading

✅ Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 4969fe5
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/625070430a437f000831a53b
😎 Deploy Preview https://deploy-preview-443--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@seokho-son seokho-son added the lang/pt for Portuguese label Feb 16, 2022
@edsoncelio edsoncelio mentioned this pull request Feb 18, 2022
Closed
jessicalins
jessicalins requested changes Feb 20, 2022
View reviewed changes
Copy link
Collaborator

@jessicalins jessicalins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Matheus, thanks for submitting this!
I've left some suggestions. I think would be nice if you could split this PR into other ones (keep the auto_scaling.md translation file in this PR and open another ones for abstraction.md and agile_software_development.md.

content/pt-br/auto_scaling.md Outdated Show resolved Hide resolved
content/pt-br/auto_scaling.md Outdated Show resolved Hide resolved
content/pt-br/auto_scaling.md Outdated Show resolved Hide resolved
content/pt-br/auto_scaling.md Outdated Show resolved Hide resolved
content/pt-br/auto_scaling.md Outdated Show resolved Hide resolved
content/pt-br/auto_scaling.md Outdated Show resolved Hide resolved
@jessicalins
Copy link
Collaborator

Hi Matheus, thanks for submitting this! I've left some suggestions. I think would be nice if you could split this PR into other ones (keep the auto_scaling.md translation file in this PR and open another ones for abstraction.md and agile_software_development.md.

I've just seen you already opened #312 - so would be missing just other PR to abstraction.md :)

jessicalins
jessicalins requested changes Feb 26, 2022
View reviewed changes
Copy link
Collaborator

@jessicalins jessicalins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!
Just a few more suggestions + I think would be nice open other PRs for 'content/pt-br/abstraction.md' and 'content/pt-br/agile_software_development.md' and leave this PR only with the 'content/pt-br/auto_scaling.md' file

content/pt-br/auto_scaling.md Outdated Show resolved Hide resolved
content/pt-br/auto_scaling.md Outdated Show resolved Hide resolved
content/pt-br/auto_scaling.md Outdated Show resolved Hide resolved
@jessicalins
Copy link
Collaborator

jessicalins commented Feb 26, 2022 •
edited
Loading

I think regarding the links to the other pages (scale, virtualizing and containerizing as in the english doc) maybe would be better actually to keep the links to the english pages? (as we did here)
Then once we have the pages translated, we'd need to update with the link to the pt page. For now I opened a ticket in our board cc @edsoncelio @brunoguidone

@edsoncelio edsoncelio removed the request for review from caniszczyk March 3, 2022 23:15
@edsoncelio
Copy link
Collaborator

Hi @matheuspaes do you need some help with the requested changes? If yes, just ping one of the reviewers on the slack :D

matheuspaesp and others added 4 commits March 28, 2022 10:01
@matheuspaesp
Update content/pt-br/auto_scaling.md
3725111 
Co-authored-by: Jéssica Lins  <jlins@redhat.com>
@matheuspaesp
Update content/pt-br/auto_scaling.md
d195f10 
Co-authored-by: Jéssica Lins  <jlins@redhat.com>
@matheuspaesp
Update content/pt-br/auto_scaling.md
ac63e04 
Co-authored-by: Jéssica Lins  <jlins@redhat.com>
@matheuspaesp
reviewed some terms
cff1f24
matheuspaesp
matheuspaesp commented Mar 28, 2022
View reviewed changes
Copy link
Contributor Author

@matheuspaesp matheuspaesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes reviewed.

@edsoncelio edsoncelio requested a review from jessicalins March 28, 2022 20:26
jessicalins
jessicalins reviewed Mar 29, 2022
View reviewed changes
Copy link
Collaborator

@jessicalins jessicalins left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good! content/pt-br/auto_scaling.md looks good to me - @matheuspaes since the process is to make one PR per translated term, could you remove agile_software_development and abstraction from this PR and open another ones for those terms?
Then I think we can approve this PR. Thanks!

jessicalins
jessicalins reviewed Mar 29, 2022
View reviewed changes
Copy link
Collaborator

@jessicalins jessicalins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @matheuspaes I've reviewed the other files as well and added a few suggestions - since this PR is opened for a while I think is fine this time to include the other files in the same PR :)

content/pt-br/abstraction.md Outdated Show resolved Hide resolved
content/pt-br/abstraction.md Outdated Show resolved Hide resolved
content/pt-br/agile_software_development.md Outdated Show resolved Hide resolved
matheuspaesp and others added 2 commits April 8, 2022 10:46
@matheuspaesp
Update content/pt-br/abstraction.md
5dce35c 
Co-authored-by: Jéssica Lins  <jlins@redhat.com>
@matheuspaesp
Update content/pt-br/agile_software_development.md
d06f47f 
Co-authored-by: Jéssica Lins  <jlins@redhat.com>
@edsoncelio edsoncelio requested a review from jessicalins April 8, 2022 14:16
jessicalins
jessicalins requested changes Apr 8, 2022
View reviewed changes
Copy link
Collaborator

@jessicalins jessicalins left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, then it is good to go 🚀

content/pt-br/abstraction.md Outdated Show resolved Hide resolved
@edsoncelio
Update content/pt-br/abstraction.md
4969fe5 
Co-authored-by: Jéssica Lins  <jlins@redhat.com>
@edsoncelio edsoncelio requested a review from jessicalins April 12, 2022 17:40
edsoncelio
edsoncelio approved these changes Apr 12, 2022
View reviewed changes
Copy link
Collaborator

@edsoncelio edsoncelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

jessicalins
jessicalins approved these changes Apr 13, 2022
View reviewed changes
Copy link
Collaborator

@jessicalins jessicalins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

edsoncelio
edsoncelio requested changes Apr 13, 2022
View reviewed changes
Copy link
Collaborator

@edsoncelio edsoncelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matheuspaes could you change the target branch from main to dev-pt?

@matheuspaesp matheuspaesp changed the base branch from main to dev-pt April 13, 2022 17:39
@matheuspaesp
Copy link
Contributor Author

@matheuspaes could you change the target branch from main to dev-pt?

alterado :) obrigado edson!!

@edsoncelio edsoncelio self-requested a review April 13, 2022 17:46
edsoncelio
edsoncelio approved these changes Apr 13, 2022
View reviewed changes
Copy link
Collaborator

@edsoncelio edsoncelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@edsoncelio edsoncelio merged commit a14166a into cncf:dev-pt Apr 13, 2022
@matheuspaesp matheuspaesp deleted the autoscaling branch July 20, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicalins jessicalins jessicalins approved these changes

@edsoncelio edsoncelio edsoncelio approved these changes

@brunoguidone brunoguidone Awaiting requested review from brunoguidone brunoguidone is a code owner

Assignees
No one assigned
Labels
lang/pt for Portuguese
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matheuspaesp @jessicalins @edsoncelio @seokho-son