Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ko] Translate 'Service Mesh' into Korean #745

Merged
merged 2 commits into from
Apr 21, 2022
Merged

[ko] Translate 'Service Mesh' into Korean #745

merged 2 commits into from
Apr 21, 2022

Conversation

jihoon-seo
Copy link
Collaborator

@jihoon-seo jihoon-seo commented Apr 14, 2022 •
edited
Loading

@jihoon-seo jihoon-seo added the lang/ko for Korean label Apr 14, 2022
@netlify
Copy link

netlify bot commented Apr 14, 2022 •
edited
Loading

✅ Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit c22f78f
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6260e3acdc74520008a4cae2
😎 Deploy Preview https://deploy-preview-745--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jihoon-seo jihoon-seo mentioned this pull request Apr 14, 2022
Closed
seokho-son
seokho-son reviewed Apr 15, 2022
View reviewed changes
Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jihoon-seo 님~ 리뷰 의견 드립니다. 참고하셔서 업데이트해주시면 되겠습니다.

content/ko/service_mesh.md Outdated Show resolved Hide resolved
content/ko/service_mesh.md Outdated Show resolved Hide resolved
content/ko/service_mesh.md Outdated Show resolved Hide resolved
content/ko/service_mesh.md Outdated Show resolved Hide resolved
content/ko/service_mesh.md Outdated Show resolved Hide resolved
@seokho-son seokho-son self-assigned this Apr 15, 2022
@cncf cncf deleted a comment from seokho-son Apr 21, 2022
@cncf cncf deleted a comment from seokho-son Apr 21, 2022
@cncf cncf deleted a comment from seokho-son Apr 21, 2022
@cncf cncf deleted a comment from seokho-son Apr 21, 2022
@jihoon-seo
Copy link
Collaborator Author

@seokho-son 리뷰 감사합니다. 😊
주신 의견을 모두 반영하였으며, 두 번째 커밋에서 확인하실 수 있습니다.

변경 사항을 쉽게 확인하실 수 있도록 squash는 아직 하지 않았으며, 필요한 경우 진행하겠습니다.
또는 "Squash and merge" 하시면서, commit 메시지의 (제목만으로도 충분할 것이므로) 내용은 모두 삭제하거나 적절히 정리하는 방법도 있겠습니다. 😊

@yunkon-kim yunkon-kim self-assigned this Apr 21, 2022
seokho-son
seokho-son approved these changes Apr 21, 2022
View reviewed changes
Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

content/ko/service_mesh.md Outdated Show resolved Hide resolved
yunkon-kim
yunkon-kim approved these changes Apr 21, 2022
View reviewed changes
Copy link
Collaborator

@yunkon-kim yunkon-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yunkon-kim yunkon-kim merged commit 60b79ee into cncf:dev-ko Apr 21, 2022
@jihoon-seo jihoon-seo deleted the 220414_Translate_Service_Mesh branch May 10, 2022 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunkon-kim yunkon-kim yunkon-kim approved these changes

@seokho-son seokho-son seokho-son approved these changes

@Eviekim Eviekim Awaiting requested review from Eviekim

Assignees

@seokho-son seokho-son

@yunkon-kim yunkon-kim

Labels
lang/ko for Korean
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jihoon-seo @seokho-son @yunkon-kim