Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: canary deployment #873

Merged
merged 1 commit into from
Jun 3, 2022
Merged

feat: canary deployment #873

merged 1 commit into from
Jun 3, 2022

Conversation

anyulled
Copy link
Contributor

@anyulled anyulled commented May 9, 2022

closes #568

@netlify
Copy link

netlify bot commented May 9, 2022 •
edited
Loading

✅ Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 0f9f513
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6299ede3107bd200084fc95c
😎 Deploy Preview https://deploy-preview-873--cncfglossary.netlify.app/es/canary_deployment
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jihoon-seo jihoon-seo added the lang/es for Spanish label May 9, 2022
@jihoon-seo jihoon-seo linked an issue May 9, 2022 that may be closed by this pull request
[Spanish] localize 'Canary Deployment' #568
Closed
@electrocucaracha
Copy link
Collaborator

@anyulled me parece que este PR debe ser creado hacia main en lugar de dev-es

@anyulled
Copy link
Contributor Author

anyulled commented May 9, 2022

oh, no lo sabía, las prs anteriores las hice a esta rama. Ahora miro de cambiarlo

@anyulled anyulled changed the base branch from dev-es to main May 9, 2022 15:03
@anyulled
Copy link
Contributor Author

anyulled commented May 9, 2022

listo @electrocucaracha gracias por la aclaratoria

@electrocucaracha
Copy link
Collaborator

@raelga @krol3 podrían revisar este PR, por favor

@anyulled
Copy link
Contributor Author

anyulled commented Jun 2, 2022 via email

raelga
raelga reviewed Jun 3, 2022
View reviewed changes
Copy link
Collaborator

@raelga raelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Algunas sugerencias.

content/es/canary_deployment.md Outdated Show resolved Hide resolved
content/es/canary_deployment.md Outdated Show resolved Hide resolved
content/es/canary_deployment.md Outdated Show resolved Hide resolved
raelga
raelga requested changes Jun 3, 2022
View reviewed changes
Copy link
Collaborator

@raelga raelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muchas gracias @anyulled, solo quedaría revisar los commits y añadir el Signed-off-by como está documentado en el test que está fallando en estos momentos:

https://github.com/cncf/glossary/pull/873/checks?check_run_id=6724356393

Si necesitas ayuda, lo podemos revisar por slack.

@anyulled anyulled force-pushed the feature/canary-deployment branch from 9a9b19d to 3f096e9 Compare June 3, 2022 11:15
@anyulled @electrocucaracha @raelga
feat: canary deployment
0f9f513 
Signed-off-by: anyul <anyulled@gmail.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Co-authored-by: Rael Garcia <rael@rael.io>
@anyulled anyulled force-pushed the feature/canary-deployment branch from 3f096e9 to 0f9f513 Compare June 3, 2022 11:17
@anyulled anyulled requested a review from raelga June 3, 2022 11:18
@anyulled
Copy link
Contributor Author

anyulled commented Jun 3, 2022

Muchas gracias @anyulled, solo quedaría revisar los commits y añadir el Signed-off-by como está documentado en el test que está fallando en estos momentos:

https://github.com/cncf/glossary/pull/873/checks?check_run_id=6724356393

Si necesitas ayuda, lo podemos revisar por slack.

Listo, ya he pasado el DCA. He cambiado de máquina y había olvidado esta parte

raelga
raelga approved these changes Jun 3, 2022
View reviewed changes
Copy link
Collaborator

@raelga raelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muchas gracias!

@anyulled
Copy link
Contributor Author

anyulled commented Jun 3, 2022

Muchas gracias!

A vosotros!

@anyulled
Copy link
Contributor Author

anyulled commented Jun 3, 2022

@electrocucaracha parece que necesito tu aprobación nuevamente

@raelga raelga changed the base branch from main to dev-es June 3, 2022 14:27
@raelga raelga merged commit 054659b into cncf:dev-es Jun 3, 2022
@raelga
Copy link
Collaborator

raelga commented Jun 3, 2022

@anyulled el problema estaba con la rama, que tenía que ir contra dev-es en vez de main.

@anyulled
Copy link
Contributor Author

anyulled commented Jun 3, 2022

@anyulled el problema estaba con la rama, que tenía que ir contra dev-es en vez de main.

Ah, gracias @raelga , entonces @electrocucaracha y yo teníamos una confusión #873 (comment)

electrocucaracha added a commit to electrocucaracha/glossary that referenced this pull request Aug 30, 2022
@anyulled @electrocucaracha @raelga
feat: canary deployment (cncf#873)
c447533 
Signed-off-by: anyul <anyulled@gmail.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Co-authored-by: Rael Garcia <rael@rael.io>
electrocucaracha added a commit to electrocucaracha/glossary that referenced this pull request Aug 30, 2022
@anyulled @electrocucaracha @raelga
feat: canary deployment (cncf#873)
29ff8e6 
Signed-off-by: anyul <anyulled@gmail.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Co-authored-by: Rael Garcia <rael@rael.io>
electrocucaracha added a commit to electrocucaracha/glossary that referenced this pull request Sep 1, 2022
@anyulled @electrocucaracha @raelga
feat: canary deployment (cncf#873)
5e2e496 
Signed-off-by: anyul <anyulled@gmail.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Co-authored-by: Rael Garcia <rael@rael.io>
electrocucaracha added a commit to electrocucaracha/glossary that referenced this pull request Sep 1, 2022
@anyulled @electrocucaracha @raelga
feat: canary deployment (cncf#873)
9abedad 
Signed-off-by: anyul <anyulled@gmail.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Co-authored-by: Rael Garcia <rael@rael.io>
seokho-son pushed a commit to seokho-son/glossary that referenced this pull request Sep 13, 2022
@anyulled @electrocucaracha
@raelga @seokho-son
feat: canary deployment (cncf#873)
41c64da 
Signed-off-by: anyul <anyulled@gmail.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Co-authored-by: Rael Garcia <rael@rael.io>
electrocucaracha added a commit to electrocucaracha/glossary that referenced this pull request Sep 14, 2022
@anyulled @electrocucaracha @raelga
feat: canary deployment (cncf#873)
967b768 
Signed-off-by: anyul <anyulled@gmail.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Co-authored-by: Rael Garcia <rael@rael.io>
ramrodo pushed a commit to ramrodo/glossary that referenced this pull request Oct 3, 2022
@anyulled @electrocucaracha
@raelga @ramrodo
feat: canary deployment (cncf#873)
6d19f48 
Signed-off-by: anyul <anyulled@gmail.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Co-authored-by: Rael Garcia <rael@rael.io>
ramrodo pushed a commit to ramrodo/glossary that referenced this pull request Dec 13, 2022
@anyulled @electrocucaracha
@raelga @ramrodo
feat: canary deployment (cncf#873)
4fd82a7 
Signed-off-by: anyul <anyulled@gmail.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Co-authored-by: Rael Garcia <rael@rael.io>
ramrodo pushed a commit to ramrodo/glossary that referenced this pull request Dec 13, 2022
@anyulled @electrocucaracha
@raelga @ramrodo
feat: canary deployment (cncf#873)
9b18104 
Signed-off-by: anyul <anyulled@gmail.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Co-authored-by: Rael Garcia <rael@rael.io>
seokho-son pushed a commit to seokho-son/glossary that referenced this pull request Mar 20, 2023
@anyulled @electrocucaracha
@raelga @seokho-son
feat: canary deployment (cncf#873)
35164f2 
Signed-off-by: anyul <anyulled@gmail.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Co-authored-by: Rael Garcia <rael@rael.io>
seokho-son pushed a commit to seokho-son/glossary that referenced this pull request Mar 20, 2023
@anyulled @electrocucaracha
@raelga @seokho-son
feat: canary deployment (cncf#873)
66b023b 
Signed-off-by: anyul <anyulled@gmail.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Co-authored-by: Rael Garcia <rael@rael.io>
seokho-son pushed a commit to seokho-son/glossary that referenced this pull request Mar 20, 2023
@anyulled @electrocucaracha
@raelga @seokho-son
feat: canary deployment (cncf#873)
dafb6a8 
Signed-off-by: anyul <anyulled@gmail.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Co-authored-by: Rael Garcia <rael@rael.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electrocucaracha electrocucaracha electrocucaracha approved these changes

@raelga raelga raelga approved these changes

@krol3 krol3 Awaiting requested review from krol3 krol3 is a code owner

Assignees
No one assigned
Labels
lang/es for Spanish
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Spanish] localize 'Canary Deployment'
4 participants
@anyulled @electrocucaracha @raelga @jihoon-seo