Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh] Update contribute & style-guide with main #881

Merged
merged 5 commits into from
May 12, 2022

Conversation

Jacob953
Copy link
Collaborator

Follow: #844
Done

  • localize contribute/_index.md to dev-zh.
  • localize style-guide/_index.md to dev-zh

@netlify
Copy link

netlify bot commented May 11, 2022

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 38ed49a
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/627cb807630cae0009c8d6c0
😎 Deploy Preview https://deploy-preview-881--cncfglossary.netlify.app/zh-cn/contribute
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@hanyuancheung hanyuancheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent!

Copy link
Collaborator

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jacob953 PTAL!

content/zh-cn/contribute/_index.md Outdated Show resolved Hide resolved
content/zh-cn/contribute/_index.md Outdated Show resolved Hide resolved
content/zh-cn/contribute/_index.md Outdated Show resolved Hide resolved
content/zh-cn/contribute/_index.md Outdated Show resolved Hide resolved
content/zh-cn/contribute/_index.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jacob953 PTAL!

content/zh-cn/contribute/_index.md Outdated Show resolved Hide resolved
content/zh-cn/contribute/_index.md Outdated Show resolved Hide resolved
content/zh-cn/contribute/_index.md Outdated Show resolved Hide resolved
content/zh-cn/contribute/_index.md Outdated Show resolved Hide resolved
content/zh-cn/contribute/_index.md Outdated Show resolved Hide resolved
@jihoon-seo
Copy link
Collaborator

Dear Chinese approvers,
please use "Squash and merge" method when merging this PR!

Copy link
Collaborator

@Rocksnake Rocksnake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these look good for me. Thanks!

@Rocksnake Rocksnake merged commit 24ab252 into cncf:dev-zh May 12, 2022
seokho-son added a commit that referenced this pull request May 12, 2022
[zh] Update contribute & style-guide with main (#881)
Jacob953 pushed a commit to Jacob953/glossary that referenced this pull request Jun 22, 2022
* feat: --20220511 update contribute with main

* feat: --20220511 update style-guide with main

* fix: --20220511 correct symble & hyperlink

* Update _index.md

* fix: --20220512 correct links

Co-authored-by: Brian Yan <18373181742@163.com>
Signed-off-by: Jacob953 <jacob953@csu.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/zh for Chinese
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants