-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge dev-zh into main(for Chinese localization live version) #844
Conversation
* site configuration * update markdown format
* site configuration * update markdown format
Update dev-zh branch with main branch
* add content/zh/cloud_computing.md and container.md localization to zh
[zh] Add 10 .md localizations
[zh] localize virtual_machine.md & virtualization.md
localize container-image.md and continous_delivery.md
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
[zh] Update dev-zh with main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jacob953 PTAL!
@Jacob953 In preview, the Chinese version of "Contributor Ladder" page is missing. |
* [zh] Update links to point localized pages * [zh] Fix links by replacing full-width parenthesis characters
* Change 'zh' to 'zh-cn' * feat: --20220509 update _index.md with main * fix: --20220509 correct punctuation * fix: --20220509 add localization contributors * feat: --20220509 localize style-guide to dev-zh Co-authored-by: Jacob953 <710297349@qq.com> Co-authored-by: Brian Yan <18373181742@163.com> Co-authored-by: Jacob953 <jacob953@csu.edu.cn>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L!G!T!M!
Thanks to the Chinese l10n team !!
FYI: The Chinese version of "How To Contribute" seems slightly outdated. 😊
Edit: The Chinese version of "Style Guide" seems slightly outdated too. 😊
Maybe we can make Chinese work go live first, and then Chinese contributors might update those pages. |
@Jacob953 yeah, pls update the content mentioned above, which is aligned with English version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, @seokho-son pls help to merge this
Hi, @jihoon-seo PTAL! I'll merge it into main as soon as #881 is done. ;) |
Merge Chinese development branch into main.
Checklist to make localization live.