Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge dev-zh into main(for Chinese localization live version) #844

Merged
merged 80 commits into from
May 11, 2022
Merged

Conversation

Jacob953
Copy link
Collaborator

@Jacob953 Jacob953 commented May 7, 2022

Merge Chinese development branch into main.

Checklist to make localization live.

hanyuancheung and others added 30 commits February 27, 2022 18:25
* site configuration

* update markdown format
* site configuration

* update markdown format
Update dev-zh branch with main branch
* add content/zh/cloud_computing.md and container.md localization to zh
[zh] Add 10 .md localizations
[zh] localize virtual_machine.md & virtualization.md
localize container-image.md and continous_delivery.md
@netlify
Copy link

netlify bot commented May 7, 2022

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 5892124
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/627b4ff651c737000928faac
😎 Deploy Preview https://deploy-preview-844--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Jacob953 Jacob953 changed the title Merge dev-zh into main Merge dev-zh into main(for Chinese localization live version) May 7, 2022
[zh] Update dev-zh with main
content/zh/_index.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jacob953 PTAL!

content/zh/contribute/_index.md Outdated Show resolved Hide resolved
content/zh/style-guide/_index.md Outdated Show resolved Hide resolved
content/zh/contribute/_index.md Outdated Show resolved Hide resolved
content/zh/style-guide/_index.md Outdated Show resolved Hide resolved
@jihoon-seo
Copy link
Collaborator

@Jacob953 In preview, the Chinese version of "Contributor Ladder" page is missing.
Could you (or anyone in Chinese L10n team) add this? 😊

jihoon-seo and others added 2 commits May 9, 2022 13:43
* [zh] Update links to point localized pages

* [zh] Fix links by replacing full-width parenthesis characters
* Change 'zh' to 'zh-cn'

* feat: --20220509 update _index.md with main

* fix: --20220509 correct punctuation

* fix: --20220509 add localization contributors

* feat: --20220509 localize style-guide to dev-zh

Co-authored-by: Jacob953 <710297349@qq.com>
Co-authored-by: Brian Yan <18373181742@163.com>
Co-authored-by: Jacob953 <jacob953@csu.edu.cn>
@Jacob953 Jacob953 mentioned this pull request May 9, 2022
3 tasks
Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L!G!T!M!

Thanks to the Chinese l10n team !!

@jihoon-seo
Copy link
Collaborator

jihoon-seo commented May 11, 2022

FYI: The Chinese version of "How To Contribute" seems slightly outdated. 😊

Edit: The Chinese version of "Style Guide" seems slightly outdated too. 😊

Maybe we can make Chinese work go live first, and then Chinese contributors might update those pages.

@hanyuancheung
Copy link
Collaborator

FYI: The Chinese version of "How To Contribute" seems slightly outdated. 😊

@Jacob953 yeah, pls update the content mentioned above, which is aligned with English version.

Copy link
Collaborator

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😊

Copy link
Collaborator

@hanyuancheung hanyuancheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @seokho-son pls help to merge this

@seokho-son seokho-son merged commit 3433505 into main May 11, 2022
@Jacob953
Copy link
Collaborator Author

Hi, @jihoon-seo PTAL!
I've update contribute/_index.md & style-guide/_index.md to dev-zh with main in #881

I'll merge it into main as soon as #881 is done. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/zh for Chinese maintainers Use this label if PR requires maintainers to take action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants