Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh] Localize contributor-ladder #874

Merged
merged 3 commits into from
May 11, 2022
Merged

[zh] Localize contributor-ladder #874

merged 3 commits into from
May 11, 2022

Conversation

Jacob953
Copy link
Collaborator

@Jacob953 Jacob953 commented May 9, 2022 •
edited by jihoon-seo
Loading

Follow: #844
Done

  • Localize contributor-ladder/_index.md to dev-zh
  • remove topnav icons
  • update links those unlocalized & correct typos following Change 'zh' to 'zh-cn' #869

@Jacob953 Jacob953 added the lang/zh for Chinese label May 9, 2022
@netlify
Copy link

netlify bot commented May 9, 2022 •
edited
Loading

✅ Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit bbc78ed
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/627a724be2ada80009eeadc4
😎 Deploy Preview https://deploy-preview-874--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Jacob953 Jacob953 mentioned this pull request May 9, 2022
Merged
7 tasks
@seokho-son
Copy link
Collaborator

Hi @Jacob953

This PR includes other commits from other authors.
I think the feature branch (Jacob953:dev-zh) needs to be rebased with the latest (upstream) dev-zh

@Jacob953
Copy link
Collaborator Author

Thank god! @seokho-son
I've taken care of the consequences of my missteps ;)

@Jacob953
Copy link
Collaborator Author

Hi, @jihoon-seo PTAL!
I've updated the links following #869, and sorry for the increase in your workload due to my poor consideration.

@seokho-son
Copy link
Collaborator

Hi @Jacob953

This PR looks good to me,
but I think at least one zh approver needs to review the localized content (content/zh-cn/contributor-ladder/_index.md)
Please invite reviewers :)

hanyuancheung
hanyuancheung approved these changes May 10, 2022
View reviewed changes
Copy link
Collaborator

@hanyuancheung hanyuancheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR looks good to me ditto!
Thank you @Jacob953

cc @seokho-son

@jihoon-seo jihoon-seo changed the title [zh] Localize contributor-labber [zh] Localize contributor-ladder May 11, 2022
Rocksnake
Rocksnake approved these changes May 11, 2022
View reviewed changes
Copy link
Collaborator

@Rocksnake Rocksnake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me. Thanks.

@Rocksnake Rocksnake merged commit 5892124 into cncf:dev-zh May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanyuancheung hanyuancheung hanyuancheung approved these changes

@Rocksnake Rocksnake Rocksnake approved these changes

@Submarinee Submarinee Awaiting requested review from Submarinee Submarinee is a code owner

Assignees
No one assigned
Labels
lang/zh for Chinese
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jacob953 @seokho-son @Rocksnake @hanyuancheung