Fixed Automate labelling issue for fork PRs #559 #853
Conversation
Signed-off-by: Sarvjeet Rajvansh <rajvanshsarvjeet@gmail.com>
| @@ -0,0 +1,22 @@ | |||
| #Add "2023" to any change to 2023 project files | |||
|
|
|||
| 2023: | |||
There was a problem hiding this comment.
Does 2023 need to be wrapped in quotes?
There was a problem hiding this comment.
If the label identifier don't contains space or any special character, quotes are optional.
common example link
There was a problem hiding this comment.
It is only a nit but I'd say change the
#Add "2023" to any change to 2023 project files
to
# Add '2023' to any change to 2023 project files
so that it is consistent with the rest of the comments in the file.
The difference is a distraction and as the other comments use single quotes then the double quoted 2023 reads as, so-called 2023
|
Thanks for looking at this @sarvjeetrajvansh! I've not looked at the labelling solutions for a while, does this solution solve the problem we ran into before where it won't label things if the source was a fork? Could you provide a link to the action page? see: #536 (comment), #547 |
Yes, this issue has been resolved after the event trigger was changed from 'pull request' to 'pull request target'. Refs :
|
makes the comment internally consistent Co-authored-by: Nate W. <natew@cncf.io> Signed-off-by: Robert Kielty <robert.kielty@cncf.io>
|
Test: #857 Thanks @sarvjeetrajvansh, looks good! |
It was my first open source contribution at CNCF |
Welcome! I'm glad you made it 🙂 |
Please review and merge it, added pr labeling feature as per Open Issue Automate labelling PRs #559