Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Automate labelling issue for fork PRs #559 #853

Merged
merged 2 commits into from
Mar 1, 2023
Merged

Fixed Automate labelling issue for fork PRs #559 #853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec68807
enhancement : Automate labelling PRs #559
sarvjeetrajvansh Feb 28, 2023
cfdaf24
Update .github/labeler.yml
RobertKielty Mar 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .github/labeler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# Add '2023' to any change to 2023 project files

2023:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does 2023 need to be wrapped in quotes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the label identifier don't contains space or any special character, quotes are optional.
common example link

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is only a nit but I'd say change the

#Add "2023" to any change to 2023 project files
to
# Add '2023' to any change to 2023 project files

so that it is consistent with the rest of the comments in the file.

The difference is a distraction and as the other comments use single quotes then the double quoted 2023 reads as, so-called 2023

- summerofcode/2023.md
- lfx-mentorship/2023/*
- lfx-mentorship/2023/**/*
- TAGCS-Mentoring-WG/2023-meeting-minutes.md

# Add 'summer of code' label to any files in the Summer of Code project
'summer of code':
- summerofcode/*
- summerofcode/**/*

# Add 'season of docs' label to any files in the season of docs project
'season of docs':
- seasonofdocs/*
- seasonofdocs/**/*

# Add 'lfx mentorship' label to any files in the lfx mentorship project
'lfx mentorship':
- lfx-mentorship/*
- lfx-mentorship/**/*
18 changes: 18 additions & 0 deletions .github/workflows/prlabeler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# This workflow is based on github action official label action v4.
# This workflow action is triggered on pull request event(on both fork & inside repo)
# Labels will be applied based on filepath modification in PR.
# This workflow uses a regex based labeling config file(.github/labeler.yml) to take labeling decision.

name: "PR Labeler"
on:
- pull_request_target
jobs:
label:
permissions:
contents: read
pull-requests: write
runs-on: ubuntu-latest
steps:
- uses: actions/labeler@v4
with:
repo-token: "${{ secrets.GITHUB_TOKEN }}"