Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This action is no longer needed, GitHub Actions (ubuntu) ships with xvfb #21

Open
fregante opened this issue Sep 7, 2023 · 6 comments

Comments

@fregante
Copy link

fregante commented Sep 7, 2023

See at the bottom of: https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md

And a successful run at https://github.com/fregante/text-field-edit/actions/runs/6107546540/workflow#L28

I'd probably add a notice to the repo and/or deprecate it.

@zm-cttae
Copy link

zm-cttae commented Sep 28, 2023

Thanks for linking the documentation. It was believed that this installation could have been an accident or some form of experimentation. We couldn't find a documentation noting XVFB officially so we continued to use the action. ✅ Support

sebastien46 added a commit to sebastien46/matrix-calculator that referenced this issue Nov 16, 2023
@bobbyg603
Copy link
Contributor

Here's an updated link https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md

@mmomtchev
Copy link

This action works on all OS, while the GA one works only on Linux

@fregante fregante changed the title This action is no longer needed, GitHub Actions ships with xvfb This action is no longer needed, GitHub Actions (ubuntu) ships with xvfb Jan 27, 2024
planger added a commit to eclipsesource/theia that referenced this issue Mar 15, 2024
As it turns out (see coactions/setup-xvfb#21), it is available in our container anyway.
Also pin the Python version to 3.11.

Change-Id: Id8d2416996ea489675ca7e50da59286af1965777
@cclauss
Copy link

cclauss commented Mar 26, 2024

This action works on all OS, while the GA one works only on Linux

- if: runner.os == 'Linux'
  run: xvfb-run npm test
- if: runner.os != 'Linux'
  run: npm test

@fregante
Copy link
Author

@laeubi
Copy link

laeubi commented Sep 25, 2024

This action works on all OS, while the GA one works only on Linux

- if: runner.os == 'Linux'
  run: xvfb-run npm test
- if: runner.os != 'Linux'
  run: npm test

This is still not really an alternative as one now needs to replicate all steps in a matrix, so can this action not simply wrap the call if appropriate and be a noop otherwhise?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants