Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add clean.sh to dist #17

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add clean.sh to dist #17

wants to merge 4 commits into from

Conversation

nfriedly
Copy link

@nfriedly nfriedly commented May 4, 2023

Fixes #14

Tested by changing to uses: tomasz-rekawek/setup-xvfb@1.0.2 (took me a minute to figure out that the tag was missing the "v")

Not sure about including the rename, this isn't my code, I'm just opening the PR here since both https://github.com/marketplace/actions/run-with-xvfb and https://github.com/marketplace/actions/gabrielbb-xvfb-action say to use this one.

CC @tomasz-rekawek

@nfriedly nfriedly requested a review from ssbarnea as a code owner May 4, 2023 18:55
@tomasz-rekawek
Copy link

@nfriedly
i just forked this one to fix this issue, and fixed it on mine fork

@bobbyg603
Copy link
Contributor

Opened another version of this PR without the action name changed #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cleanup.sh is not present in dist
3 participants