Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GJKSolver] Fix missing switch case in result status of GJK #387

Merged
merged 1 commit into from
Mar 24, 2023
Merged

[GJKSolver] Fix missing switch case in result status of GJK #387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion include/hpp/fcl/narrowphase/narrowphase.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,7 @@ struct HPP_FCL_DLLAPI GJKSolver {
}
break;
case details::GJK::Valid:
case details::GJK::EarlyStopped:
case details::GJK::Failed:
col = false;

Expand All @@ -250,7 +251,7 @@ struct HPP_FCL_DLLAPI GJKSolver {
break;
default:
assert(false && "should not reach type part.");
return true;
throw std::logic_error("GJKSolver: should not reach this part.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The assert just before should be removed I think.

}
return col;
}
Expand Down