Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add citations #449

Merged
merged 6 commits into from
Jul 26, 2023
Merged

Add citations #449

merged 6 commits into from
Jul 26, 2023

Conversation

jcarpent
Copy link
Contributor

Related to #446

nim65s
nim65s previously approved these changes Jul 24, 2023
@jcarpent
Copy link
Contributor Author

Currently, we have some issues with Eigen 3.4.1 as there is compilation bugs in it that been solved since then.
We will need to enforce the fact that Eigen 3.4.1 should not be used.

@nim65s
Copy link
Contributor

nim65s commented Jul 26, 2023

I'm a bit lost on the eigen 3.4.1 issue. Could you share a link, or copy/paste an error you get, or explain a bit what is this issue ?

On another topic, when you say "We will need to enforce the fact that Eigen 3.4.1 should not be used.", what do you mean, if b2673f5 is not doing that ?

@jcarpent
Copy link
Contributor Author

I'm a bit lost on the eigen 3.4.1 issue. Could you share a link, or copy/paste an error you get, or explain a bit what is this issue ?

On another topic, when you say "We will need to enforce the fact that Eigen 3.4.1 should not be used.", what do you mean, if b2673f5 is not doing that ?

Yes, sorry. It seems that the issue was only related to conda-forge, in fact. They have automated the process, and it has proceed the branch 3.4.1. See conda-forge/eigen-feedstock#39 for further info.

@jcarpent jcarpent merged commit e050e6d into coal-library:devel Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants