Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eigen 3.4.1 release? #39

Closed
traversaro opened this issue Jul 22, 2023 · 5 comments · Fixed by #40
Closed

Eigen 3.4.1 release? #39

traversaro opened this issue Jul 22, 2023 · 5 comments · Fixed by #40
Labels

Comments

@traversaro
Copy link
Contributor

Comment:

I saw that we the autotick bot updated Eigen to 3.4.1 . However, I could not find any reference to Eigen 3.4.1 in Eigen website or tags. I just found a 3.4.1 branch, but I am not sure if that is intended to be a release. I will open an issue upstream in Eigen, but anyhow I wanted to open an issue here to track this.

@traversaro
Copy link
Contributor Author

Downstream issue: https://gitlab.com/libeigen/eigen/-/issues/2702 .

@jcarpent
Copy link

I do agree with @traversaro, there is no official release of Eigen 3.4.1. In addition, this branch is causing compilation errors on upstream projects. I do think this new release on conda-forge should be marked as deprecated or irrelevant.

@jcarpent
Copy link

Here is the list of all releases: https://gitlab.com/libeigen/eigen/-/releases

@traversaro
Copy link
Contributor Author

traversaro commented Jul 25, 2023

Upstream confirmed in https://gitlab.com/libeigen/eigen/-/issues/2702 that 3.4.1 branch is not a release. I think we should mark 3.4.1 as broken, and remember to avoid using the build number 0 once 3.4.1 actually gets released. I can't easily to a PR to mark Eigen as broken as for a week I only have smartphone access, so if anyone wants to do it it is welcome, thanks! fyi @conda-forge/eigen

@traversaro
Copy link
Contributor Author

As a follow up, the bug that created compilation errors with the "fake" 3.4.1 release was fixed in https://gitlab.com/libeigen/eigen/-/merge_requests/1412, so we should be fine when the "real" 3.4.1 release is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants