Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenCV 4.8.0 #371

Merged
merged 7 commits into from
Jul 22, 2023
Merged

OpenCV 4.8.0 #371

merged 7 commits into from
Jul 22, 2023

Conversation

ilya-lavrenov
Copy link
Contributor

@ilya-lavrenov ilya-lavrenov commented Jul 19, 2023

Description:

  • Updated OpenCV to 4.8.0 version
  • Added OpenVINO dependency to optimize DNN module to faster perform inference of DL models
  • Updated macOS SDK version for x86_64 because of this patch in 4.8.0
  • Pinned eigen dependency, because newer patch version (released today) has issues with compilation.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor

Thanks for the help on this front!

Added OpenVINO dependency to optimize DNN module to faster perform inference of DL models

Are you comfortable with conda-forge? do you maintain any other conda-forge feedstocks??

To debug the build failures, it may be really helpful to disable much of the python build matrix to avoid unecessary CI usage

@ilya-lavrenov
Copy link
Contributor Author

@conda-forge-admin, please rerender

@ilya-lavrenov
Copy link
Contributor Author

ilya-lavrenov commented Jul 21, 2023

Thanks for the help on this front!

Added OpenVINO dependency to optimize DNN module to faster perform inference of DL models

Are you comfortable with conda-forge? do you maintain any other conda-forge feedstocks??

To debug the build failures, it may be really helpful to disable much of the python build matrix to avoid unecessary CI usage

Hi!
Yes, I am the author of:

and maintainer of:

@ilya-lavrenov ilya-lavrenov requested a review from hmaarrfk July 21, 2023 10:42
@@ -85,7 +85,7 @@ requirements:
host:
- python
- numpy
- eigen
- eigen =3.4.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change

Copy link
Contributor Author

@ilya-lavrenov ilya-lavrenov Jul 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it's stated in the description: Pinned eigen dependency, because newer patch version (released today) has issues with compilation.
Since it's a header only library, it's just harmless change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI, that version of eigen was not actually meant to be released: conda-forge/eigen-feedstock#39 .

Copy link
Contributor

@hmaarrfk hmaarrfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Mostly I want to give others a chance to chime in on adding you as a maintainer

@hmaarrfk
Copy link
Contributor

let me know if you are OK splitting this PR in two:

  1. a faster merge for opencv 4.8
  2. a longer time to allow others to add you as a maintainer here.

removed new maintainers
@hmaarrfk
Copy link
Contributor

@conda-forge-admin please rerender

@hmaarrfk hmaarrfk added the automerge Merge the PR when CI passes label Jul 22, 2023
@github-actions github-actions bot merged commit 891639f into conda-forge:main Jul 22, 2023
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants