-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenCV 4.8.0 #371
OpenCV 4.8.0 #371
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Thanks for the help on this front!
Are you comfortable with conda-forge? do you maintain any other conda-forge feedstocks?? To debug the build failures, it may be really helpful to disable much of the python build matrix to avoid unecessary CI usage |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.07.19.16.49.37
Hi!
and maintainer of: |
@@ -85,7 +85,7 @@ requirements: | |||
host: | |||
- python | |||
- numpy | |||
- eigen | |||
- eigen =3.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it's stated in the description: Pinned eigen dependency, because newer patch version (released today) has issues with compilation.
Since it's a header only library, it's just harmless change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just FYI, that version of eigen was not actually meant to be released: conda-forge/eigen-feedstock#39 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Mostly I want to give others a chance to chime in on adding you as a maintainer
let me know if you are OK splitting this PR in two:
|
removed new maintainers
@conda-forge-admin please rerender |
…nda-forge-pinning 2023.07.21.17.52.19
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
Description:
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)