[broadphase] Initialize NodeVecIterator #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case where only 2 shapes are used and one of them is a shape with infinite AABB (i.e Plane or Halfspace), `min_size` remains equal to +infinity in `HierarchyTree::bottomup` and `min_it1` and `min_it2` never got set, which was leading to a segfault when they are then dereferenced.
nim65s
added a commit
to nim65s/robotpkg
that referenced
this pull request
Jan 27, 2024
Upstream changes:
## [2.4.1] - 2024-01-23
### Fixed
- CachedMeshLoader checks file last modification time.
- Fix call to clear methods for {Collision,Distance}Data inside init function (coal-library/coal#509)
- CMake: fix submodule use in bindings in (coal-library/coal#512)
- Fix bug in DynamicAABBTreeCollisionManager (see coal-library/coal#514) in (coal-library/coal#515)
Packaging changes:
- added patch-522 to fix assimp detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case where only 2 shapes are used and one of them is a shape with infinite AABB (i.e Plane or Halfspace),
min_sizeremains equal to +infinity inHierarchyTree::bottomupandmin_it1andmin_it2never got set, which was leading to a segfault when they are then dereferenced.