Adds break and continue tags.
#26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, | ||
| _ => {} | ||
| } | ||
| }; |
There was a problem hiding this comment.
can you quickly elaborate (and maybe write a short comment) why you need to collect the nesting_depth here?
|
Mmh, this one is a bit tricky. I'm usually not a big fan of changing things all around the code to support a single tag. But in this case there really seems to be no better alternative. I left a few minor comments :) |
Adds the notion of an "interrupt" - a signal in the rendering context that stops all rendering and returns the rendered content back up the call stack. When the stack unwind hits a for_loop, it resets the interrupt and continues processing as directed - either breaking out of the loop or continuing on to the next iteration.
|
👍 great, thanks! |
epage
added a commit
to epage/liquid-rust
that referenced
this pull request
Feb 3, 2025
Update CONTRIBUTING.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the notion of an "interrupt" - a signal in the rendering context that stops all rendering and returns the rendered content back up the call stack. When the stack unwind hits a for_loop, it resets the
interrupt and continues processing as directed - either breaking out of the loop or continuing on to the next iteration.
The
breakandcontinuetags are then implemented on top of this interrupt construct. This is pretty much how the shopify implementation handles the same problem.Also adds support for nested tags in the parser (e.g. nested
for_loop,if, etc). Prior to this, the parser would truncate the children at the innerendtag.