Adds unless and elsif support
#27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I merged your #26, wanna rebase? :) |
|
Rebased. |
tcsc
force-pushed
the
unless
branch
4 times, most recently
from
e8db609 to
f8c7d1c
Compare
Adds `unless` support to the if_block.rs module. Also adds support for `elsif` blocks in an `if`, which are parsed into recursive else blocks. Also adds a sub-block aware splitter function that can be used to split a tag body on any of a set of delimiters, where the split is guaranteed to happen at the top levek of nesting (e.g, attempting to split the tokens inside an `if` block on an `else` is guaranteed to split the token stream only on an `else` block at the same nesting level as the `if` (as opposed to, say, the `else` block of a `for_loop` nested inside the body of the `if`). Rewrites the `for_loop` parser to use the new sub-block aware splitter.
|
Sorry, took me a while to look at this but I wanted to be sure I understand the BlockSplit concept. I think I can live with this solution, thanks for the effort! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
unlesssupport (see #23) to the if_block.rs module. Also addssupport for
elsifblocks in anif, which are parsed intorecursive else blocks.
Also adds a sub-block aware splitter function that can be used to
split a tag body on any of a set of delimiters, where the split is
guaranteed to happen at the top levek of nesting (e.g, attempting
to split the tokens inside an
ifblock on anelseis guaranteedto split the token stream only on an
elseblock at the samenesting level as the
if(as opposed to, say, theelseblock ofa
for_loopnested inside the body of theif).